[https://nvbugs/5808603][fix] Add bias support to WeightOnlyQuantLinearMethod#12317
[https://nvbugs/5808603][fix] Add bias support to WeightOnlyQuantLinearMethod#12317stnie merged 1 commit intoNVIDIA:mainfrom
Conversation
…arMethod and update corresponding tests - Modified WeightOnlyQuantLinearMethod to include bias in the output calculation. - Updated test_weight_only_quant_linear to parameterize bias and validate its effect on output. Signed-off-by: Stefan Niebler <82932102+stnie@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #39446 [ run ] triggered by Bot. Commit: |
|
PR_Github #39446 [ run ] completed with state |
📝 WalkthroughWalkthroughAdds bias support to the Linear module's apply method by conditionally adding a bias tensor to the output. Extends the weight-only quantized linear test with parameterized bias cases, including bias tensor creation, loading, and reference output adjustment. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip You can disable the changed files summary in the walkthrough.Disable the |
Summary by CodeRabbit
Bug Fixes
Tests
Description
WeightOnlyQuantLinearMethods did not apply bias, which is for example used in Qwen2.5 models
This PR:
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.