Skip to content

[None][chore] Add failed cases into waives.txt#12328

Merged
jieli-matrix merged 5 commits intoNVIDIA:mainfrom
jieli-matrix:user/qa/post_update_waive_20260319_LLM_FUNCTION_TEST_2007
Mar 19, 2026
Merged

[None][chore] Add failed cases into waives.txt#12328
jieli-matrix merged 5 commits intoNVIDIA:mainfrom
jieli-matrix:user/qa/post_update_waive_20260319_LLM_FUNCTION_TEST_2007

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Mar 18, 2026

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test skip list with three additional test cases to address known issues.

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Jie Li <76780849+jieli-matrix@users.noreply.github.com>
…ION_TEST_2007

Signed-off-by: Jie Li <76780849+jieli-matrix@users.noreply.github.com>
@jieli-matrix jieli-matrix marked this pull request as ready for review March 19, 2026 07:50
@jieli-matrix jieli-matrix enabled auto-merge (squash) March 19, 2026 07:50
@jieli-matrix
Copy link
Collaborator

/bot run --stage-list ""

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2026

📝 Walkthrough

Walkthrough

Added three test cases to the skip waives list with associated bug tracking references, affecting tests related to LLM API accuracy and disaggregated model runtime.

Changes

Cohort / File(s) Summary
Test Waives List
tests/integration/test_lists/waives.txt
Added three SKIP entries for failing tests: LLM API PyTorch chunked prefill test, disaggregated transceiver runtime test, and LLM API Eagle3 autodeploy test, each linked to NVIDIA bug tracking references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • StanleySun639
  • LarryXFly
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal and does not follow the repository's template structure, missing key sections like detailed description and test coverage. Expand the description to follow the template: include detailed explanation of why these cases are being waived, and confirm no new test coverage is needed since this is a configuration change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding failed test cases to the waives.txt file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes with custom instructions.

Set the reviews.auto_title_instructions setting to generate a title for your PR based on the changes in the PR with custom instructions.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 384-386: Replace the three occurrences of insecure NVBugs links by
updating "http://nvbugs/5997547", "http://nvbugs/5997543", and
"http://nvbugs/5997534" to use HTTPS (i.e., "https://nvbugs/<id>") in the waiver
list so all nvbugs links follow the preferred https://nvbugs/<id> format.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9b1d59c1-71ee-4e67-b7ad-78a466f7cf97

📥 Commits

Reviewing files that changed from the base of the PR and between f7dedd0 and 77bb8d7.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Signed-off-by: Jie Li <76780849+jieli-matrix@users.noreply.github.com>
@jieli-matrix
Copy link
Collaborator

/bot run --stage-list ""

@tensorrt-cicd
Copy link
Collaborator

PR_Github #39569 [ run ] triggered by Bot. Commit: babf49c Link to invocation

@tensorrt-cicd
Copy link
Collaborator

PR_Github #39570 [ run ] triggered by Bot. Commit: babf49c Link to invocation

@tensorrt-cicd
Copy link
Collaborator

PR_Github #39569 [ run ] completed with state ABORTED. Commit: babf49c

Link to invocation

@tensorrt-cicd
Copy link
Collaborator

PR_Github #39570 [ run ] completed with state SUCCESS. Commit: babf49c
/LLM/main/L0_MergeRequest_PR pipeline #30784 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@jieli-matrix
Copy link
Collaborator

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #39578 [ reuse-pipeline ] triggered by Bot. Commit: e675881 Link to invocation

@tensorrt-cicd
Copy link
Collaborator

PR_Github #39578 [ reuse-pipeline ] completed with state SUCCESS. Commit: e675881
Reusing PR_Github #39570 (Partly Tested) for commit e675881

Link to invocation

@jieli-matrix jieli-matrix merged commit 42ba371 into NVIDIA:main Mar 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants