Skip to content

[None][chore] Remove gpu-shell tool from ad-run-agent#12418

Merged
govind-ramnarayan merged 5 commits intoNVIDIA:mainfrom
nv-auto-deploy:gramnarayan/remove-gpu-shell-from-ad-run-agent
Apr 6, 2026
Merged

[None][chore] Remove gpu-shell tool from ad-run-agent#12418
govind-ramnarayan merged 5 commits intoNVIDIA:mainfrom
nv-auto-deploy:gramnarayan/remove-gpu-shell-from-ad-run-agent

Conversation

@govind-ramnarayan
Copy link
Copy Markdown
Collaborator

@govind-ramnarayan govind-ramnarayan commented Mar 21, 2026

Summary by CodeRabbit

  • Documentation

    • Updated agent execution instructions to use standard bash and shell execution paths instead of GPU-shell tools.
  • Chores

    • Streamlined agent configuration for simplified command execution workflows.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

The gpu-shell tool is no longer needed - plain Bash works for GPU
commands in the current environment. Update all references in the
ad-run-agent to use Bash instead.

Signed-off-by: Govind Ramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
Clean up leftover gpu-shell mentions in ad_run_agent.toml and
ad_debug_agent.toml to match the ad-run-agent.md cleanup.

Signed-off-by: Govind Ramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
@govind-ramnarayan govind-ramnarayan marked this pull request as ready for review April 2, 2026 07:05
@govind-ramnarayan govind-ramnarayan enabled auto-merge (squash) April 2, 2026 07:05
@govind-ramnarayan
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0719a358-0275-4d4a-a45c-7762cc22b8b4

📥 Commits

Reviewing files that changed from the base of the PR and between 2c809ae and 3e42786.

📒 Files selected for processing (3)
  • .claude/agents/ad-run-agent.md
  • .codex/agents/ad_debug_agent.toml
  • .codex/agents/ad_run_agent.toml

📝 Walkthrough

Walkthrough

This PR updates agent documentation and configuration files to standardize execution instructions by removing gpu-shell references and replacing them with standard shell execution guidance across ad-run and ad-debug agent configurations.

Changes

Cohort / File(s) Summary
ad-run Agent Documentation & Configuration
.claude/agents/ad-run-agent.md, .codex/agents/ad_run_agent.toml
Removed gpu-shell from front-matter description, tools list, and execution instructions. Updated narrative guidance from "gpu-shell" execution to "Bash" execution. Modified "Notes" section in TOML to reference "standard shell execution path" instead of "available shell execution path."
ad-debug Agent Configuration
.codex/agents/ad_debug_agent.toml
Removed constraint from developer_instructions that directed users toward environment-specific GPU access paths, simplifying execution guidance.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description lacks actual content in required sections (Description, Test Coverage) and is only a template with comments. Essential details about the change rationale and testing are missing. Fill in the Description section explaining why gpu-shell was removed and what changes were made. Complete the Test Coverage section with relevant test cases or deployment validation steps.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically indicates the main change: removing the gpu-shell tool from ad-run-agent. It directly matches the changeset content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41374 [ run ] triggered by Bot. Commit: 3e42786 Link to invocation

@govind-ramnarayan
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41504 [ run ] triggered by Bot. Commit: 998b6eb Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41504 [ run ] completed with state SUCCESS. Commit: 998b6eb
/LLM/main/L0_MergeRequest_PR pipeline #32422 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@govind-ramnarayan
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41742 [ run ] triggered by Bot. Commit: dc80f66 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41742 [ run ] completed with state SUCCESS. Commit: dc80f66
/LLM/main/L0_MergeRequest_PR pipeline #32643 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@govind-ramnarayan
Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41958 [ run ] triggered by Bot. Commit: dc80f66 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41958 [ run ] completed with state SUCCESS. Commit: dc80f66
/LLM/main/L0_MergeRequest_PR pipeline #32814 completed with status: 'SUCCESS'

CI Report

Link to invocation

@govind-ramnarayan govind-ramnarayan merged commit 889b81c into NVIDIA:main Apr 6, 2026
5 checks passed
@govind-ramnarayan govind-ramnarayan deleted the gramnarayan/remove-gpu-shell-from-ad-run-agent branch April 6, 2026 23:08
xinhe-nv pushed a commit to xinhe-nv/TensorRT-LLM that referenced this pull request Apr 7, 2026
Signed-off-by: Govind Ramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Apr 7, 2026
Signed-off-by: Govind Ramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
karen-sy pushed a commit to karen-sy/TensorRT-LLM that referenced this pull request Apr 7, 2026
Signed-off-by: Govind Ramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants