[https://nvbugs/5850183][fix] Re-enable passing tests#12568
[https://nvbugs/5850183][fix] Re-enable passing tests#12568dongfengy merged 2 commits intoNVIDIA:mainfrom
Conversation
8acd7e0 to
c26aba8
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoved 8 waiver entries from a test skip list for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
c26aba8 to
6b5279c
Compare
|
/bot run |
|
PR_Github #40572 [ run ] triggered by Bot. Commit: |
|
PR_Github #40572 [ run ] completed with state
|
6b5279c to
8e0fd3f
Compare
|
/bot run |
|
PR_Github #40596 [ run ] triggered by Bot. Commit: |
|
PR_Github #40596 [ run ] completed with state |
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot run --add-multi-gpu-test |
|
PR_Github #40655 [ run ] triggered by Bot. Commit: |
|
PR_Github #40655 [ run ] completed with state
|
8e0fd3f to
cc2c85c
Compare
|
/bot run --add-multi-gpu-test |
|
PR_Github #40741 [ run ] triggered by Bot. Commit: |
|
PR_Github #40741 [ run ] completed with state
|
|
/bot run --add-multi-gpu-test |
|
PR_Github #40795 [ run ] triggered by Bot. Commit: |
|
PR_Github #40795 [ run ] completed with state
|
cc2c85c to
a5d5a1d
Compare
|
/bot run --add-multi-gpu-test |
|
PR_Github #40814 [ run ] triggered by Bot. Commit: |
|
PR_Github #40814 [ run ] completed with state
|
|
PR_Github #40959 [ run ] triggered by Bot. Commit: |
|
PR_Github #40959 [ run ] completed with state
|
b7c0a0b to
e8eecbb
Compare
|
/bot run --add-multi-gpu-test |
|
PR_Github #41018 [ run ] triggered by Bot. Commit: |
|
PR_Github #41018 [ run ] completed with state
|
e8eecbb to
68c480e
Compare
|
/bot run --add-multi-gpu-test |
|
PR_Github #41067 [ run ] triggered by Bot. Commit: |
|
PR_Github #41067 [ run ] completed with state
|
Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
68c480e to
67bf206
Compare
|
/bot run --add-multi-gpu-test |
|
PR_Github #41213 [ run ] triggered by Bot. Commit: |
|
PR_Github #41213 [ run ] completed with state
|
|
/bot run --add-multi-gpu-test |
|
PR_Github #41265 [ run ] triggered by Bot. Commit: |
|
PR_Github #41265 [ run ] completed with state |
Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
|
/bot skip "Test list changes. Already passed. But then need to deal with merge conflicts" |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot skip --comment "Test list changes. Already passed. But then need to deal with merge conflicts" |
|
/bot reuse-pipeline |
2 similar comments
|
/bot reuse-pipeline |
|
/bot reuse-pipeline |
|
PR_Github #41318 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #41318 [ reuse-pipeline ] completed with state |
Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com> Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
No failure on GB200 with 48 runs
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.