Skip to content

[https://nvbugs/5850183][fix] Re-enable passing tests#12568

Merged
dongfengy merged 2 commits intoNVIDIA:mainfrom
dongfengy:user/dongfengy/gptoss_dp4_acc
Apr 2, 2026
Merged

[https://nvbugs/5850183][fix] Re-enable passing tests#12568
dongfengy merged 2 commits intoNVIDIA:mainfrom
dongfengy:user/dongfengy/gptoss_dp4_acc

Conversation

@dongfengy
Copy link
Copy Markdown
Collaborator

@dongfengy dongfengy commented Mar 29, 2026

No failure on GB200 with 48 runs

Summary by CodeRabbit

  • Tests
    • Removed test waivers for multi-GPU configurations, enabling stricter validation of model optimization variants and cache implementations across different backend configurations.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@dongfengy dongfengy force-pushed the user/dongfengy/gptoss_dp4_acc branch from 8acd7e0 to c26aba8 Compare March 29, 2026 04:28
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dd42193b-5520-49d3-a42d-668b20a784fd

📥 Commits

Reviewing files that changed from the base of the PR and between 8ce0518 and c26aba8.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Removed 8 waiver entries from a test skip list for test_w4_4gpus test cases, eliminating skip configurations across various combinations of kv_cache versions, execution plans (ep4, dp4), and quantization backends (trtllm-auto, trtllm-fp8).

Changes

Cohort / File(s) Summary
Test Waiver List
tests/integration/test_lists/waives.txt
Removed 8 SKIP waiver entries for TestGPTOSS::test_w4_4gpus test configurations involving v1_kv_cache and v2_kv_cache variants with ep4 and dp4 execution plans across trtllm-auto and trtllm-fp8 backends.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description only contains a template with a one-line summary and mostly empty sections. Required sections like Description, Test Coverage, and PR Checklist are incomplete. Fill in the Description section explaining why tests are being re-enabled, detail Test Coverage showing which tests now pass, and address relevant checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: removing waiver entries for tests that now pass, enabling them in CI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@dongfengy dongfengy force-pushed the user/dongfengy/gptoss_dp4_acc branch from c26aba8 to 6b5279c Compare March 29, 2026 04:31
@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40572 [ run ] triggered by Bot. Commit: 6b5279c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40572 [ run ] completed with state SUCCESS. Commit: 6b5279c
/LLM/main/L0_MergeRequest_PR pipeline #31613 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@dongfengy dongfengy force-pushed the user/dongfengy/gptoss_dp4_acc branch from 6b5279c to 8e0fd3f Compare March 29, 2026 15:05
@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40596 [ run ] triggered by Bot. Commit: 8e0fd3f Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40596 [ run ] completed with state SUCCESS. Commit: 8e0fd3f
/LLM/main/L0_MergeRequest_PR pipeline #31637 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

CI Report

Link to invocation

@dongfengy dongfengy requested a review from EmmaQiaoCh March 30, 2026 00:10
@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot help

@github-actions
Copy link
Copy Markdown

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test

@dongfengy dongfengy requested a review from yizhang-nv March 30, 2026 04:53
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40655 [ run ] triggered by Bot. Commit: 8e0fd3f Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40655 [ run ] completed with state SUCCESS. Commit: 8e0fd3f
/LLM/main/L0_MergeRequest_PR pipeline #31690 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@dongfengy dongfengy force-pushed the user/dongfengy/gptoss_dp4_acc branch from 8e0fd3f to cc2c85c Compare March 30, 2026 15:31
@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40741 [ run ] triggered by Bot. Commit: cc2c85c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40741 [ run ] completed with state SUCCESS. Commit: cc2c85c
/LLM/main/L0_MergeRequest_PR pipeline #31761 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40795 [ run ] triggered by Bot. Commit: cc2c85c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40795 [ run ] completed with state SUCCESS. Commit: cc2c85c
/LLM/main/L0_MergeRequest_PR pipeline #31810 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@dongfengy dongfengy force-pushed the user/dongfengy/gptoss_dp4_acc branch from cc2c85c to a5d5a1d Compare March 31, 2026 01:43
@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40814 [ run ] triggered by Bot. Commit: a5d5a1d Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40814 [ run ] completed with state SUCCESS. Commit: a5d5a1d
/LLM/main/L0_MergeRequest_PR pipeline #31828 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40959 [ run ] triggered by Bot. Commit: b7c0a0b Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40959 [ run ] completed with state FAILURE. Commit: b7c0a0b
/LLM/main/L0_MergeRequest_PR pipeline #31947 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@dongfengy dongfengy force-pushed the user/dongfengy/gptoss_dp4_acc branch from b7c0a0b to e8eecbb Compare March 31, 2026 21:10
@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41018 [ run ] triggered by Bot. Commit: e8eecbb Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41018 [ run ] completed with state FAILURE. Commit: e8eecbb
/LLM/main/L0_MergeRequest_PR pipeline #31998 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@dongfengy dongfengy force-pushed the user/dongfengy/gptoss_dp4_acc branch from e8eecbb to 68c480e Compare April 1, 2026 01:51
@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41067 [ run ] triggered by Bot. Commit: 68c480e Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41067 [ run ] completed with state FAILURE. Commit: 68c480e
/LLM/main/L0_MergeRequest_PR pipeline #32043 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
@dongfengy dongfengy force-pushed the user/dongfengy/gptoss_dp4_acc branch from 68c480e to 67bf206 Compare April 1, 2026 15:20
@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41213 [ run ] triggered by Bot. Commit: 67bf206 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41213 [ run ] completed with state SUCCESS. Commit: 67bf206
/LLM/main/L0_MergeRequest_PR pipeline #32175 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41265 [ run ] triggered by Bot. Commit: 67bf206 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41265 [ run ] completed with state SUCCESS. Commit: 67bf206
/LLM/main/L0_MergeRequest_PR pipeline #32223 completed with status: 'SUCCESS'

CI Report

Link to invocation

Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot skip "Test list changes. Already passed. But then need to deal with merge conflicts"

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Test list changes. Already passed. But then need to deal with merge conflicts"

@dongfengy dongfengy enabled auto-merge (squash) April 2, 2026 03:03
@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot reuse-pipeline

2 similar comments
@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot reuse-pipeline

@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41318 [ reuse-pipeline ] triggered by Bot. Commit: f65fc5c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41318 [ reuse-pipeline ] completed with state SUCCESS. Commit: f65fc5c
Reusing PR_Github #41265 for commit f65fc5c

Link to invocation

@dongfengy dongfengy merged commit b581ac4 into NVIDIA:main Apr 2, 2026
5 checks passed
karen-sy pushed a commit to karen-sy/TensorRT-LLM that referenced this pull request Apr 7, 2026
Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
Signed-off-by: dongfengy <99041270+dongfengy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants