Skip to content

[https://nvbugs/5997543][fix] unwaive test_disaggregated_overlap_transceiver_runtime_python#12580

Merged
chuangz0 merged 1 commit intoNVIDIA:mainfrom
chuangz0:unwaive_transceiver_python_runtime_test
Apr 7, 2026
Merged

[https://nvbugs/5997543][fix] unwaive test_disaggregated_overlap_transceiver_runtime_python#12580
chuangz0 merged 1 commit intoNVIDIA:mainfrom
chuangz0:unwaive_transceiver_python_runtime_test

Conversation

@chuangz0
Copy link
Copy Markdown
Collaborator

@chuangz0 chuangz0 commented Mar 30, 2026

Summary by CodeRabbit

  • Tests
    • Enabled validation for a previously excluded test case, improving test coverage.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@chuangz0
Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6fb936d3-d196-4515-8cc7-1709b24e98c4

📥 Commits

Reviewing files that changed from the base of the PR and between f0b336e and fba08cd.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A single test waiver entry for disaggregated/test_disaggregated.py::test_disaggregated_overlap_transceiver_runtime_python[TinyLlama-1.1B-Chat-v1.0] with its associated NVBug reference was removed from the test waiver list file.

Changes

Cohort / File(s) Summary
Test Waiver List
tests/integration/test_lists/waives.txt
Removed a single test waiver entry for a disaggregated test case with TinyLlama model, including its NVBug link reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description contains only the template with empty sections (no actual description, test coverage details, or justification provided by the author). Fill in the Description section explaining why the test waive is being removed and the Test Coverage section listing the affected test.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed Title follows the required format with NVBugs ID and [fix] type, clearly indicating that the test waive is being removed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40674 [ run ] triggered by Bot. Commit: fba08cd Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40674 [ run ] completed with state SUCCESS. Commit: fba08cd
/LLM/main/L0_MergeRequest_PR pipeline #31705 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@chuangz0
Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40844 [ run ] triggered by Bot. Commit: fba08cd Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40844 [ run ] completed with state SUCCESS. Commit: fba08cd
/LLM/main/L0_MergeRequest_PR pipeline #31853 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@chuangz0
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40898 [ run ] triggered by Bot. Commit: fba08cd Link to invocation

@chuangz0 chuangz0 force-pushed the unwaive_transceiver_python_runtime_test branch from fba08cd to e998b74 Compare April 1, 2026 05:36
@chuangz0
Copy link
Copy Markdown
Collaborator Author

chuangz0 commented Apr 1, 2026

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41118 [ run ] triggered by Bot. Commit: e998b74 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41118 [ run ] completed with state SUCCESS. Commit: e998b74
/LLM/main/L0_MergeRequest_PR pipeline #32091 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@chuangz0 chuangz0 force-pushed the unwaive_transceiver_python_runtime_test branch from e998b74 to 9c39d05 Compare April 2, 2026 08:18
@chuangz0
Copy link
Copy Markdown
Collaborator Author

chuangz0 commented Apr 2, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41390 [ run ] triggered by Bot. Commit: 9c39d05 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41390 [ run ] completed with state SUCCESS. Commit: 9c39d05
/LLM/main/L0_MergeRequest_PR pipeline #32330 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@chuangz0 chuangz0 force-pushed the unwaive_transceiver_python_runtime_test branch from 9c39d05 to 64d021c Compare April 3, 2026 02:38
@chuangz0
Copy link
Copy Markdown
Collaborator Author

chuangz0 commented Apr 3, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41564 [ run ] triggered by Bot. Commit: 64d021c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41564 [ run ] completed with state SUCCESS. Commit: 64d021c
/LLM/main/L0_MergeRequest_PR pipeline #32475 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
@chuangz0 chuangz0 force-pushed the unwaive_transceiver_python_runtime_test branch from 64d021c to 3802641 Compare April 7, 2026 01:39
@chuangz0
Copy link
Copy Markdown
Collaborator Author

chuangz0 commented Apr 7, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42018 [ run ] triggered by Bot. Commit: 3802641 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42018 [ run ] completed with state SUCCESS. Commit: 3802641
/LLM/main/L0_MergeRequest_PR pipeline #32864 completed with status: 'SUCCESS'

CI Report

Link to invocation

@chuangz0 chuangz0 enabled auto-merge (squash) April 7, 2026 09:54
@chuangz0 chuangz0 merged commit 54d182a into NVIDIA:main Apr 7, 2026
5 checks passed
@Shixiaowei02 Shixiaowei02 deleted the unwaive_transceiver_python_runtime_test branch April 7, 2026 11:56
karen-sy pushed a commit to karen-sy/TensorRT-LLM that referenced this pull request Apr 7, 2026
…sceiver_runtime_python (NVIDIA#12580)

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
suyoggupta pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Apr 8, 2026
…sceiver_runtime_python (NVIDIA#12580)

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants