Skip to content

[None][infra] Bump etcd to 3.6.9 to involve grpc fix#12594

Merged
niukuo merged 1 commit intoNVIDIA:mainfrom
yuanjingx87:user/yuanjingx/bump_etcd
Apr 8, 2026
Merged

[None][infra] Bump etcd to 3.6.9 to involve grpc fix#12594
niukuo merged 1 commit intoNVIDIA:mainfrom
yuanjingx87:user/yuanjingx/bump_etcd

Conversation

@yuanjingx87
Copy link
Copy Markdown
Collaborator

@yuanjingx87 yuanjingx87 commented Mar 30, 2026

Summary by CodeRabbit

  • Chores
    • Updated etcd installation to version 3.6.9.

Description

Bump etcd which involves a vulnerability fix for grpc

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@yuanjingx87 yuanjingx87 requested review from a team as code owners March 30, 2026 18:29
@yuanjingx87 yuanjingx87 requested review from mzweilz and niukuo March 30, 2026 18:29
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

📝 Walkthrough

Walkthrough

The etcd installation script is updated to install version v3.6.9 instead of v3.5.21 by modifying the ETCD_VER variable. The download URL path and tarball filename are adjusted accordingly, while all other installation logic remains unchanged.

Changes

Cohort / File(s) Summary
etcd Version Update
docker/common/install_etcd.sh
Updated ETCD_VER constant from v3.5.21 to v3.6.9, which changes the constructed download URL and tarball name used during installation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive PR title is properly formatted with ticket and type. However, the Description section is minimal, lacking detailed explanation of the vulnerability fix and rationale beyond brief mention. Expand the Description section to explain the specific gRPC vulnerability being fixed, the impact of the vulnerability, and why upgrading etcd to 3.6.9 addresses it. Also clarify Test Coverage section expectations.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: bumping etcd to version 3.6.9 to address a gRPC vulnerability fix, which directly matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@yuanjingx87
Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40762 [ run ] triggered by Bot. Commit: 71560b2 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40762 [ run ] completed with state SUCCESS. Commit: 71560b2
/LLM/main/L0_MergeRequest_PR pipeline #31779 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@yuanjingx87 yuanjingx87 requested a review from a team as a code owner March 31, 2026 07:22
@yuanjingx87
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40894 [ run ] triggered by Bot. Commit: f28c2f1 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40894 [ run ] completed with state FAILURE. Commit: f28c2f1
/LLM/main/L0_MergeRequest_PR pipeline #31896 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@yuanjingx87
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40983 [ run ] triggered by Bot. Commit: f28c2f1 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40983 [ run ] completed with state FAILURE. Commit: f28c2f1
/LLM/main/L0_MergeRequest_PR pipeline #31965 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@yuanjingx87 yuanjingx87 force-pushed the user/yuanjingx/bump_etcd branch from f28c2f1 to a3e4daf Compare March 31, 2026 22:52
@yuanjingx87
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41035 [ run ] triggered by Bot. Commit: a3e4daf Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41035 [ run ] completed with state SUCCESS. Commit: a3e4daf
/LLM/main/L0_MergeRequest_PR pipeline #32015 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@yuanjingx87 yuanjingx87 force-pushed the user/yuanjingx/bump_etcd branch from a3e4daf to d7a2c95 Compare April 1, 2026 17:31
@yuanjingx87
Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41240 [ run ] triggered by Bot. Commit: d7a2c95 Link to invocation

@yuanjingx87
Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

1 similar comment
@yuanjingx87
Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41313 [ run ] triggered by Bot. Commit: d7a2c95 Link to invocation

Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
@yuanjingx87 yuanjingx87 force-pushed the user/yuanjingx/bump_etcd branch from d7a2c95 to d185b54 Compare April 2, 2026 17:12
@yuanjingx87
Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41473 [ run ] triggered by Bot. Commit: d185b54 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41473 [ run ] completed with state FAILURE. Commit: d185b54
/LLM/main/L0_MergeRequest_PR pipeline #32399 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@niukuo
Copy link
Copy Markdown
Collaborator

niukuo commented Apr 8, 2026

/bot skip --comment "docker build stage pass"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42343 [ skip ] triggered by Bot. Commit: d185b54 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42343 [ skip ] completed with state SUCCESS. Commit: d185b54
Skipping testing for commit d185b54

Link to invocation

@niukuo niukuo merged commit 9fed1ef into NVIDIA:main Apr 8, 2026
5 checks passed
niukuo pushed a commit to niukuo/TensorRT-LLM that referenced this pull request Apr 9, 2026
Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
Signed-off-by: Yiteng Niu <6831097+niukuo@users.noreply.github.com>
niukuo added a commit that referenced this pull request Apr 9, 2026
Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
Signed-off-by: Yiteng Niu <6831097+niukuo@users.noreply.github.com>
Co-authored-by: yuanjingx87 <197832395+yuanjingx87@users.noreply.github.com>
yuanjingx87 added a commit to yuanjingx87/TensorRT-LLM that referenced this pull request Apr 9, 2026
…VIDIA#12872)

Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
Signed-off-by: Yiteng Niu <6831097+niukuo@users.noreply.github.com>
Co-authored-by: yuanjingx87 <197832395+yuanjingx87@users.noreply.github.com>
yuanjingx87 added a commit to yuanjingx87/TensorRT-LLM that referenced this pull request Apr 10, 2026
…VIDIA#12872)

Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
Signed-off-by: Yiteng Niu <6831097+niukuo@users.noreply.github.com>
Co-authored-by: yuanjingx87 <197832395+yuanjingx87@users.noreply.github.com>
yuanjingx87 added a commit to yuanjingx87/TensorRT-LLM that referenced this pull request Apr 10, 2026
…VIDIA#12872)

Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
Signed-off-by: Yiteng Niu <6831097+niukuo@users.noreply.github.com>
Co-authored-by: yuanjingx87 <197832395+yuanjingx87@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants