[None][test] Fix kimi-k2 test issue#12604
Conversation
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
📝 WalkthroughWalkthroughRefactored the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/defs/perf/test_perf.py (1)
1-1:⚠️ Potential issue | 🟠 MajorUpdate the SPDX copyright year for this modified file.
Line 1 still ends at
2025; since this file is modified in this PR, it should include2026.Proposed fix
-# SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. +# SPDX-FileCopyrightText: Copyright (c) 2022-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.As per coding guidelines "Add NVIDIA copyright header on ALL new files, and update year on modified files".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/integration/defs/perf/test_perf.py` at line 1, Update the SPDX copyright header year on this modified file by changing the year range ending from 2025 to 2026 in the SPDX line (the top-of-file SPDX header string).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@tests/integration/defs/perf/test_perf.py`:
- Line 1: Update the SPDX copyright header year on this modified file by
changing the year range ending from 2025 to 2026 in the SPDX line (the
top-of-file SPDX header string).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bdc33c5c-1d1b-4210-be17-63c61a2705f5
📒 Files selected for processing (1)
tests/integration/defs/perf/test_perf.py
|
/bot skip --comment "only test list modify" |
|
PR_Github #40859 [ skip ] triggered by Bot. Commit: |
|
PR_Github #40859 [ skip ] completed with state |
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Summary by CodeRabbit
Can pass in local https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/view/TRT-LLM-Perf-Pipelines/job/TRT-LLM-Perf-Test-Cluster/677/allure/#suites/1391e8d00208145d2c262e76f0a53c75/9faccf8a54ad2e02/
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.