Skip to content

[None][test] Fix kimi-k2 test issue#12604

Merged
yufeiwu-nv merged 2 commits intoNVIDIA:mainfrom
yufeiwu-nv:fix_kimi
Apr 1, 2026
Merged

[None][test] Fix kimi-k2 test issue#12604
yufeiwu-nv merged 2 commits intoNVIDIA:mainfrom
yufeiwu-nv:fix_kimi

Conversation

@yufeiwu-nv
Copy link
Copy Markdown
Collaborator

@yufeiwu-nv yufeiwu-nv commented Mar 31, 2026

Summary by CodeRabbit

Can pass in local https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/view/TRT-LLM-Perf-Pipelines/job/TRT-LLM-Perf-Test-Cluster/677/allure/#suites/1391e8d00208145d2c262e76f0a53c75/9faccf8a54ad2e02/

  • Tests
    • Improved command invocation structure for performance benchmarking tests to better handle model trust configuration across different scenarios.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@yufeiwu-nv yufeiwu-nv requested a review from a team as a code owner March 31, 2026 03:02
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

📝 Walkthrough

Walkthrough

Refactored the get_prepare_data_command method in the performance test module to restructure trtllm-bench prepare-dataset command arguments into separate list entries across both LoRA and non-LoRA paths. Added conditional inclusion of --trust-remote-code flag based on model configuration.

Changes

Cohort / File(s) Summary
Test Command Refactoring
tests/integration/defs/perf/test_perf.py
Restructured command argument construction from combined elements to individual list entries. Added conditional --trust-remote-code flag appending when model is in TRUST_REMOTE_CODE_MODELS. Changes applied to both LoRA and non-LoRA code paths in get_prepare_data_command.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR description is completely unfilled—it contains only the template with no actual content under Description, Test Coverage, or explanation of the changes. Fill in the Description section explaining what the test issue was and how it was fixed. Specify which tests validate the changes and confirm all PR checklist items are addressed.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the change as a test fix for the kimi-k2 issue, and the format follows the repository template with [None][test] convention.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
tests/integration/defs/perf/test_perf.py (1)

1-1: ⚠️ Potential issue | 🟠 Major

Update the SPDX copyright year for this modified file.

Line 1 still ends at 2025; since this file is modified in this PR, it should include 2026.

Proposed fix
-# SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-FileCopyrightText: Copyright (c) 2022-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.

As per coding guidelines "Add NVIDIA copyright header on ALL new files, and update year on modified files".

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@tests/integration/defs/perf/test_perf.py` at line 1, Update the SPDX
copyright header year on this modified file by changing the year range ending
from 2025 to 2026 in the SPDX line (the top-of-file SPDX header string).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@tests/integration/defs/perf/test_perf.py`:
- Line 1: Update the SPDX copyright header year on this modified file by
changing the year range ending from 2025 to 2026 in the SPDX line (the
top-of-file SPDX header string).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bdc33c5c-1d1b-4210-be17-63c61a2705f5

📥 Commits

Reviewing files that changed from the base of the PR and between 0e9fbc1 and 75ad27e.

📒 Files selected for processing (1)
  • tests/integration/defs/perf/test_perf.py

@yufeiwu-nv
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "only test list modify"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40859 [ skip ] triggered by Bot. Commit: b5abba0 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40859 [ skip ] completed with state SUCCESS. Commit: b5abba0
Skipping testing for commit b5abba0

Link to invocation

@yufeiwu-nv yufeiwu-nv enabled auto-merge (squash) March 31, 2026 07:36
@yufeiwu-nv yufeiwu-nv merged commit 3676be4 into NVIDIA:main Apr 1, 2026
7 checks passed
karen-sy pushed a commit to karen-sy/TensorRT-LLM that referenced this pull request Apr 7, 2026
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants