[TRTLLM-9948][infra] Move to use FlexCache in Austin for 5080 nodes#12615
Conversation
|
/bot run --stage-list "RTX5080-TensorRT-1, RTX5080-TensorRT-2" |
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@jenkins/L0_Test.groovy`:
- Line 1776: Update the stale inline comment that mentions "rtx-pro-6000d, gh200
and rtx-5080" and FlexCache to reflect the current routing logic—remove
reference to "gh200" (since the code no longer routes gh200 to FlexCache) and
make the comment accurately describe which nodes are routed to FlexCache (e.g.,
"rtx-pro-6000d and rtx-5080 nodes are located in Austin DC; we use the FlexCache
to speed up data access"). Locate the comment near the routing condition that
references FlexCache and these node names and edit the text accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6e900923-3d63-4625-92f0-dd40a126300d
📒 Files selected for processing (1)
jenkins/L0_Test.groovy
|
PR_Github #40900 [ run ] triggered by Bot. Commit: |
|
PR_Github #40900 [ run ] completed with state |
|
/bot run --stage-list "RTX5080-TensorRT-1, RTX5080-TensorRT-2" |
|
PR_Github #41177 [ run ] triggered by Bot. Commit: |
|
PR_Github #41177 [ run ] completed with state |
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot run --stage-list "RTX5080-TensorRT-1, RTX5080-TensorRT-2" --disable-reuse-test |
1 similar comment
|
/bot run --stage-list "RTX5080-TensorRT-1, RTX5080-TensorRT-2" --disable-reuse-test |
|
PR_Github #41356 [ run ] triggered by Bot. Commit: |
|
PR_Github #41356 [ run ] completed with state |
|
/bot run |
|
PR_Github #41397 [ run ] triggered by Bot. Commit: |
|
PR_Github #41397 [ run ] completed with state
|
c659694 to
a376112
Compare
|
/bot run |
|
PR_Github #41565 [ run ] triggered by Bot. Commit: |
|
PR_Github #41565 [ run ] completed with state
|
Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
a376112 to
824d907
Compare
|
/bot run |
|
PR_Github #42039 [ run ] triggered by Bot. Commit: |
|
PR_Github #42039 [ run ] completed with state
|
|
The execution time is less than when we use the scratch in SC. |
…VIDIA#12615) Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
…VIDIA#12615) Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
…VIDIA#12615) Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.