[None][test] remove unused tests#12625
Conversation
xinhe-nv
force-pushed
the
tests
branch
2 times, most recently
from
049e549 to
c8d2331
Compare
xinhe-nv
changed the title
|
/bot run |
📝 WalkthroughWalkthroughThis pull request removes a large set of integration tests across 27 test files in the test suite. The deletions span accuracy tests (CLI flow, LLM API variants, disaggregated serving), example tests (speculative decoding, quantization configurations, multi-GPU scenarios), end-to-end tests, and sanity checks. No new tests or functionality are introduced; the changes strictly reduce test coverage across multiple model configurations and hardware setups. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ❌ 3❌ Failed checks (1 warning, 2 inconclusive)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/defs/accuracy/test_cli_flow.py (1)
1-15:⚠️ Potential issue | 🟡 MinorAddress pre-commit hook failures.
The pipeline shows failures from
ruff(9 errors) andruff-format(2 files reformatted). Please run pre-commit hooks locally to fix formatting issues:pre-commit run --all-filesOr apply formatting with:
ruff check --fix . ruff format .🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/integration/defs/accuracy/test_cli_flow.py` around lines 1 - 15, Run the project's pre-commit hooks to fix ruff/format issues (e.g., run "pre-commit run --all-files" or run "ruff check --fix ." and "ruff format ."), then stage and commit the changed files; the failing file contains the test module (symbol "pytest" in test_cli_flow.py) so ensure its formatting and ruff lint errors are resolved before pushing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/integration/defs/accuracy/test_cli_flow.py`:
- Line 64: Remove the four stale test references from the test-list YAML
(l0_dgx_h200.yml): delete the entries referencing
accuracy/test_cli_flow.py::TestLlama2_7B::test_smooth_quant_ootb_tp2,
::test_int4_awq_tp2, ::test_int4_awq_prequantized_tp2, and
::test_int4_gptq_prequantized_tp2 so the YAML no longer points to deleted test
methods and CI test selection stops failing.
---
Outside diff comments:
In `@tests/integration/defs/accuracy/test_cli_flow.py`:
- Around line 1-15: Run the project's pre-commit hooks to fix ruff/format issues
(e.g., run "pre-commit run --all-files" or run "ruff check --fix ." and "ruff
format ."), then stage and commit the changed files; the failing file contains
the test module (symbol "pytest" in test_cli_flow.py) so ensure its formatting
and ruff lint errors are resolved before pushing.
🪄 Autofix (Beta)
❌ Autofix failed (check again to retry)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e67871d7-c3aa-4ac8-b288-1680c9bd327f
📒 Files selected for processing (28)
tests/integration/defs/accuracy/test_cli_flow.pytests/integration/defs/accuracy/test_disaggregated_serving.pytests/integration/defs/accuracy/test_llm_api.pytests/integration/defs/accuracy/test_llm_api_autodeploy.pytests/integration/defs/accuracy/test_llm_api_pytorch.pytests/integration/defs/examples/serve/test_spec_decoding_metrics.pytests/integration/defs/examples/test_ad_guided_decoding.pytests/integration/defs/examples/test_ad_speculative_decoding.pytests/integration/defs/examples/test_bindings.pytests/integration/defs/examples/test_commandr.pytests/integration/defs/examples/test_draft_target_model.pytests/integration/defs/examples/test_eagle.pytests/integration/defs/examples/test_flux.pytests/integration/defs/examples/test_gemma.pytests/integration/defs/examples/test_gpt.pytests/integration/defs/examples/test_gptj.pytests/integration/defs/examples/test_llama.pytests/integration/defs/examples/test_medusa.pytests/integration/defs/examples/test_mistral.pytests/integration/defs/examples/test_mixtral.pytests/integration/defs/examples/test_nemotron.pytests/integration/defs/examples/test_nemotron_nas.pytests/integration/defs/examples/test_phi.pytests/integration/defs/examples/test_qwen.pytests/integration/defs/examples/test_qwenvl.pytests/integration/defs/test_e2e.pytests/integration/defs/test_mlpf_results.pytests/integration/defs/test_sanity.py
💤 Files with no reviewable changes (26)
- tests/integration/defs/examples/test_commandr.py
- tests/integration/defs/examples/test_ad_guided_decoding.py
- tests/integration/defs/accuracy/test_disaggregated_serving.py
- tests/integration/defs/test_sanity.py
- tests/integration/defs/examples/serve/test_spec_decoding_metrics.py
- tests/integration/defs/examples/test_bindings.py
- tests/integration/defs/examples/test_flux.py
- tests/integration/defs/examples/test_draft_target_model.py
- tests/integration/defs/examples/test_ad_speculative_decoding.py
- tests/integration/defs/test_mlpf_results.py
- tests/integration/defs/examples/test_qwenvl.py
- tests/integration/defs/examples/test_nemotron.py
- tests/integration/defs/examples/test_gptj.py
- tests/integration/defs/accuracy/test_llm_api_autodeploy.py
- tests/integration/defs/examples/test_phi.py
- tests/integration/defs/accuracy/test_llm_api_pytorch.py
- tests/integration/defs/examples/test_gemma.py
- tests/integration/defs/examples/test_nemotron_nas.py
- tests/integration/defs/examples/test_mistral.py
- tests/integration/defs/examples/test_mixtral.py
- tests/integration/defs/examples/test_eagle.py
- tests/integration/defs/accuracy/test_llm_api.py
- tests/integration/defs/examples/test_qwen.py
- tests/integration/defs/test_e2e.py
- tests/integration/defs/examples/test_gpt.py
- tests/integration/defs/examples/test_medusa.py
|
PR_Github #41060 [ run ] triggered by Bot. Commit: |
|
PR_Github #41060 [ run ] completed with state
|
|
/bot run |
|
PR_Github #41076 [ run ] triggered by Bot. Commit: |
|
PR_Github #41076 [ run ] completed with state
|
|
/bot run |
|
PR_Github #41112 [ run ] triggered by Bot. Commit: |
|
/bot run |
|
PR_Github #41112 [ run ] completed with state
|
|
/bot run |
|
PR_Github #41148 [ run ] triggered by Bot. Commit: |
|
PR_Github #41148 [ run ] completed with state
|
|
/bot run |
|
PR_Github #41293 [ run ] triggered by Bot. Commit: |
|
PR_Github #41293 [ run ] completed with state
|
|
/bot run |
|
PR_Github #41350 [ run ] triggered by Bot. Commit: |
|
PR_Github #41350 [ run ] completed with state |
|
/bot run --post-merge |
|
PR_Github #42270 [ run ] completed with state
|
|
/bot run --post-merge |
|
PR_Github #42312 [ run ] triggered by Bot. Commit: |
|
PR_Github #42314 [ run ] triggered by Bot. Commit: |
|
PR_Github #42312 [ run ] completed with state |
|
PR_Github #42314 [ run ] completed with state
|
|
/bot run --post-merge |
|
PR_Github #42421 [ run ] triggered by Bot. Commit: |
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
|
/bot run --stage-list "" |
|
PR_Github #42484 [ run ] triggered by Bot. Commit: |
|
PR_Github #42421 [ run ] completed with state |
|
PR_Github #42484 [ run ] completed with state |
|
/bot reuse-pipeline |
|
PR_Github #42527 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #42527 [ reuse-pipeline ] completed with state |
|
/bot reuse-pipeline |
|
PR_Github #42538 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #42538 [ reuse-pipeline ] completed with state |
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found. |
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found. |
6 participants
@coderabbitai summary
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.