[https://nvbugs/5813192][fix] Make trust_remote_code opt-in in MultimodalModelRunner#12669
Conversation
Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>
800b96b to
d5b0ce4
Compare
📝 WalkthroughWalkthroughA CLI flag Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@examples/models/core/multimodal/utils.py`:
- Around line 130-136: The return parser is incorrectly indented inside the
parser.add_argument(...) call causing a syntax error; move the return statement
out to the same indentation level as the parser.add_argument(...) call so that
return parser executes after the add_argument call (locate the
parser.add_argument invocation for '--trust_remote_code' and un-indent the
return parser to be outside that call).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 52b92403-9ee6-4ffd-bd92-919bc661cc65
📒 Files selected for processing (2)
examples/models/core/multimodal/utils.pytensorrt_llm/runtime/multimodal_model_runner.py
Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>
|
/bot run |
|
PR_Github #41571 [ run ] triggered by Bot. Commit: |
|
PR_Github #41571 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #41685 [ run ] triggered by Bot. Commit: |
|
PR_Github #41685 [ run ] completed with state |
Summary by CodeRabbit
--trust_remote_codeCLI flag for multimodal model loading, enabling users to control remote code execution during model initialization (disabled by default for enhanced security).Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.