Skip to content

[None][test] Remove OOM test case from L40S test list#12685

Merged
yufeiwu-nv merged 9 commits intoNVIDIA:mainfrom
yufeiwu-nv:fix_L40S
Apr 3, 2026
Merged

[None][test] Remove OOM test case from L40S test list#12685
yufeiwu-nv merged 9 commits intoNVIDIA:mainfrom
yufeiwu-nv:fix_L40S

Conversation

@yufeiwu-nv
Copy link
Copy Markdown
Collaborator

@yufeiwu-nv yufeiwu-nv commented Apr 2, 2026

Summary by CodeRabbit

  • Tests
    • Updated performance test configuration for optimized test execution across GPU environments.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
@yufeiwu-nv yufeiwu-nv requested review from a team as code owners April 2, 2026 08:49
@yufeiwu-nv yufeiwu-nv requested a review from nv-yilinf April 2, 2026 08:49
@yufeiwu-nv yufeiwu-nv changed the title Remove OOM test case from L40S test list [None][test] Remove OOM test case from L40S test list Apr 2, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c809535d-9f81-4c7f-8cf4-a7a68ca08b50

📥 Commits

Reviewing files that changed from the base of the PR and between d309646 and 0571ad1.

📒 Files selected for processing (1)
  • tests/integration/test_lists/qa/llm_perf_core.yml

📝 Walkthrough

Walkthrough

A test case for starcoder2_15b PyTorch bfloat16 with specific parameters was relocated from one GPU/compute capability condition block to another in the performance test list configuration.

Changes

Cohort / File(s) Summary
Test Configuration
tests/integration/test_lists/qa/llm_perf_core.yml
Moved starcoder2_15b PyTorch bfloat16 test case (input_output_len:500,2000, con:100) from "L20, L40S, H100, H20, H200" condition block to "H100, H20, H200, GB200, B200, B300, GB300, RTX6000-D, RTX6000-Server" condition block.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template with empty sections (Description, Test Coverage) and unchecked checklist items, providing no actual explanation of the change, rationale, or test coverage details. Fill in the Description section explaining why the test case was moved from L40S to the higher-spec GPU block, and complete the Test Coverage section documenting relevant tests affected by this change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove OOM test case from L40S test list' directly reflects the main change: moving a test case from the L40S GPU condition block to a higher-spec GPU block to resolve an out-of-memory issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@yufeiwu-nv
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "only test list adjuestment"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41401 [ skip ] triggered by Bot. Commit: 0571ad1 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41401 [ skip ] completed with state SUCCESS. Commit: 0571ad1
Skipping testing for commit 0571ad1

Link to invocation

@yufeiwu-nv
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "only test list adjuestment"

@yufeiwu-nv yufeiwu-nv enabled auto-merge (squash) April 3, 2026 08:28
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41635 [ skip ] triggered by Bot. Commit: 6fe30f0 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41635 [ skip ] completed with state SUCCESS. Commit: 6fe30f0
Skipping testing for commit 6fe30f0

Link to invocation

@yufeiwu-nv yufeiwu-nv merged commit 2e4d6a4 into NVIDIA:main Apr 3, 2026
5 checks passed
govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Apr 6, 2026
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
karen-sy pushed a commit to karen-sy/TensorRT-LLM that referenced this pull request Apr 7, 2026
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants