Skip to content

[None][infra] Waive failure test#12726

Merged
yiqingy0 merged 1 commit intoNVIDIA:mainfrom
yiqingy0:waive_failure_test
Apr 3, 2026
Merged

[None][infra] Waive failure test#12726
yiqingy0 merged 1 commit intoNVIDIA:mainfrom
yiqingy0:waive_failure_test

Conversation

@yiqingy0
Copy link
Copy Markdown
Collaborator

@yiqingy0 yiqingy0 commented Apr 3, 2026

Summary by CodeRabbit

  • Tests
    • Updated test configuration waivers to skip a performance test under specific hardware and input configuration conditions.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
@yiqingy0
Copy link
Copy Markdown
Collaborator Author

yiqingy0 commented Apr 3, 2026

/bot skip --comment "Waive test"

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

📝 Walkthrough

Walkthrough

A single line was added to the test waiver file to skip a specific performance test configuration for the deepseek_r1_distill_qwen_32b model under specific resource constraints, referencing a known issue.

Changes

Cohort / File(s) Summary
Test Waiver Entry
tests/integration/test_lists/waives.txt
Added skip entry for perf/test_perf.py::test_perf targeting deepseek_r1_distill_qwen_32b model with float16 precision, autodeploy, and 1024x1024 input/output lengths at 512 requests per second, linked to bug #6044213.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • chzblych
  • longlee0622
🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely composed of the template with no actual content filled in—no description, test coverage, or rationale provided. Fill in the Description section explaining why the test is being waived, provide relevant test coverage information, and ensure the title follows the specified format with a proper ticket reference.
Title check ❓ Inconclusive The title '[None][infra] Waive failure test' is related to the changeset which adds a waive entry for a failing test, but it is vague and uses imprecise language ('failure test' is unclear). Clarify the title to specifically identify which test is being waived and why, e.g., '[None][infra] Waive perf/test_perf.py::test_perf for deepseek_r1_distill_qwen_32b benchmark'.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41583 [ skip ] triggered by Bot. Commit: 541dd9e Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41583 [ skip ] completed with state SUCCESS. Commit: 541dd9e
Skipping testing for commit 541dd9e

Link to invocation

@yiqingy0 yiqingy0 merged commit 1df4923 into NVIDIA:main Apr 3, 2026
8 of 10 checks passed
@yiqingy0 yiqingy0 deleted the waive_failure_test branch April 3, 2026 04:24
govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Apr 6, 2026
Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
Co-authored-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
karen-sy pushed a commit to karen-sy/TensorRT-LLM that referenced this pull request Apr 7, 2026
Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
Co-authored-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants