Skip to content

[None][chore] Remove closed bugs#12766

Merged
xinhe-nv merged 11 commits intoNVIDIA:mainfrom
xinhe-nv:user/qa/unwaive_20260405
Apr 8, 2026
Merged

[None][chore] Remove closed bugs#12766
xinhe-nv merged 11 commits intoNVIDIA:mainfrom
xinhe-nv:user/qa/unwaive_20260405

Conversation

@xinhe-nv
Copy link
Copy Markdown
Collaborator

@xinhe-nv xinhe-nv commented Apr 5, 2026

Remove closed bugs from waives.txt

Summary by CodeRabbit

  • Tests
    • Removed skip waivers for multiple GPU-distributed test cases across various model variants and configurations, enabling comprehensive testing of DeepSeek, Llama, GLM, and GPT-OSS implementations with different data types and distributed settings.

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
xinhe-nv added 2 commits April 7, 2026 10:27
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv xinhe-nv marked this pull request as ready for review April 7, 2026 02:28
@xinhe-nv xinhe-nv enabled auto-merge (squash) April 7, 2026 02:28
@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

xinhe-nv commented Apr 7, 2026

/bot run

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 601129d2-3a5c-4985-8fb4-feee92244a63

📥 Commits

Reviewing files that changed from the base of the PR and between 4496e69 and 8dcca07.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This PR removes 11 SKIP waiver entries from the test waives list for specific GPU-distributed accuracy test parametrizations across accuracy/test_llm_api_pytorch.py, including variants for DeepSeekV3Lite, Llama4ScoutInstruct, GLM4_6, and GPTOSS models with different hardware configurations and optimizations.

Changes

Cohort / File(s) Summary
Waiver List Updates
tests/integration/test_lists/waives.txt
Removed 11 SKIP waiver entries for GPU-distributed LLM accuracy test parametrizations, un-waiving tests for DeepSeekV3Lite (bfloat16/fp8), Llama4ScoutInstruct (auto-dtype), GLM4_6 (throughput_trtllm), GPTOSS (eagle3_4gpus and w4_2gpus variants with different schedulers and dtypes).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
  • jieli-matrix
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal and lacks required sections like explanation of the issue/solution and test coverage details specified in the template. Expand the description to explain which bugs were closed and why they are being removed, and clarify the test coverage for this change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing closed bug waivers from the waives.txt file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42034 [ run ] triggered by Bot. Commit: 8dcca07 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42034 [ run ] completed with state SUCCESS. Commit: 8dcca07
/LLM/main/L0_MergeRequest_PR pipeline #32880 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

xinhe-nv commented Apr 7, 2026

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42081 [ run ] triggered by Bot. Commit: dc9abea Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42081 [ run ] completed with state FAILURE. Commit: dc9abea
/LLM/main/L0_MergeRequest_PR pipeline #32920 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

xinhe-nv commented Apr 7, 2026

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42104 [ run ] triggered by Bot. Commit: 8373f5a Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42104 [ run ] completed with state SUCCESS. Commit: 8373f5a
/LLM/main/L0_MergeRequest_PR pipeline #32943 completed with status: 'SUCCESS'

CI Report

Link to invocation

@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

xinhe-nv commented Apr 8, 2026

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42224 [ reuse-pipeline ] triggered by Bot. Commit: d5d405c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42224 [ reuse-pipeline ] completed with state SUCCESS. Commit: d5d405c
Reusing PR_Github #42104 for commit d5d405c

Link to invocation

@xinhe-nv xinhe-nv merged commit 4311c11 into NVIDIA:main Apr 8, 2026
5 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/unwaive_20260405 branch April 8, 2026 02:21
suyoggupta pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Apr 8, 2026
Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants