[None][test] Remove RTX-6000 OOM test cases#12800
Conversation
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
|
/bot skip --comment "only test list modify" |
👎 Promotion blocked, new vulnerability foundVulnerability report
|
📝 WalkthroughWalkthroughThe stall timeout for command execution in performance utilities was increased from 600 to 1800 seconds, with documentation comments added. Performance test cases for deepseek_r1_0528_fp4 were reorganized across different GPU system configurations in the test list. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/integration/defs/perf/utils.py`:
- Around line 135-138: The comments above the constants _STALL_TIMEOUT and
_ERROR_STALL_TIMEOUT violate PEP 8 E265 by missing a space after the '#'
characters; update the two comment lines that precede those constants so each
'#' is followed by a single space (e.g., "# if hang time > 30 mins, it will be
killed") to fix the lint error while leaving the constant names and values
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f8627007-c275-47aa-a5fc-f02cc3b1a2da
📒 Files selected for processing (2)
tests/integration/defs/perf/utils.pytests/integration/test_lists/qa/llm_perf_core.yml
|
/bot skip --comment "only test list modify" |
|
PR_Github #42119 [ skip ] triggered by Bot. Commit: |
|
PR_Github #42119 [ skip ] completed with state |
Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
Summary by CodeRabbit
Release Notes
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.