Skip to content

[None][chore] Waive hanging Nemotron Super test#12821

Merged
brb-nv merged 1 commit intoNVIDIA:mainfrom
brb-nv:user/brb/waive-nemotron-super-v3-autodeploy
Apr 8, 2026
Merged

[None][chore] Waive hanging Nemotron Super test#12821
brb-nv merged 1 commit intoNVIDIA:mainfrom
brb-nv:user/brb/waive-nemotron-super-v3-autodeploy

Conversation

@brb-nv
Copy link
Copy Markdown
Collaborator

@brb-nv brb-nv commented Apr 8, 2026

Description

Waive failing test blocking pre-merge.

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

  • Chores
    • Updated test configuration and waivers.

Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2831d000-7067-40c8-a2e4-be322159d52d

📥 Commits

Reviewing files that changed from the base of the PR and between 3bd37ae and eee5ba8.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A new waiver entry is added to the test waiver list, marking accuracy/test_llm_api_autodeploy.py::TestNemotronSuperV3::test_accuracy with parameterization [fp8-4-attn_dp_off-trtllm] as skipped, with reference to bug link https://nvbugs/6058066.

Changes

Cohort / File(s) Summary
Test Waiver Configuration
tests/integration/test_lists/waives.txt
Added one waiver entry to skip a specific test case for accuracy testing on Nemotron Super V3 with FP8 quantization and attention distributed parallelism disabled.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • yuxianq
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description includes the required sections (Description and Test Coverage) but lacks detail. The description is minimal and doesn't explain which specific test is being waived or why it's hanging. Expand the description to specify the test name, reason for the waiver, and expected resolution timeline or next steps for fixing the underlying issue.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: waiving a hanging Nemotron Super test, which directly corresponds to the PR's objective of addressing a failing test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@brb-nv
Copy link
Copy Markdown
Collaborator Author

brb-nv commented Apr 8, 2026

/bot skip --comment "Waive test blocking pre-merge"

@brb-nv brb-nv enabled auto-merge (squash) April 8, 2026 01:26
@brb-nv brb-nv removed the request for review from ZhanruiSunCh April 8, 2026 01:30
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42213 [ skip ] triggered by Bot. Commit: eee5ba8 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42213 [ skip ] completed with state SUCCESS. Commit: eee5ba8
Skipping testing for commit eee5ba8

Link to invocation

@brb-nv brb-nv merged commit adc7af6 into NVIDIA:main Apr 8, 2026
8 checks passed
suyoggupta pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Apr 8, 2026
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants