Skip to content

[https://nvbugs/5940463][fix] remove test_cli_flow.py::TestSantacoder case#12845

Merged
QiJune merged 1 commit intoNVIDIA:mainfrom
QiJune:remove_santacoder
Apr 10, 2026
Merged

[https://nvbugs/5940463][fix] remove test_cli_flow.py::TestSantacoder case#12845
QiJune merged 1 commit intoNVIDIA:mainfrom
QiJune:remove_santacoder

Conversation

@QiJune
Copy link
Copy Markdown
Collaborator

@QiJune QiJune commented Apr 8, 2026

Summary by CodeRabbit

  • Tests
    • Removed a deprecated test case and its associated waiver entry from the integration test suite.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
@QiJune QiJune requested a review from a team as a code owner April 8, 2026 12:41
@QiJune
Copy link
Copy Markdown
Collaborator Author

QiJune commented Apr 8, 2026

/bot run

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2c0281f1-eae2-4bd0-a7fc-0402e6b76d16

📥 Commits

Reviewing files that changed from the base of the PR and between 72226d9 and 8e6e083.

📒 Files selected for processing (3)
  • tests/integration/defs/accuracy/test_cli_flow.py
  • tests/integration/test_lists/test-db/l0_gh200.yml
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (3)
  • tests/integration/test_lists/waives.txt
  • tests/integration/defs/accuracy/test_cli_flow.py
  • tests/integration/test_lists/test-db/l0_gh200.yml

📝 Walkthrough

Walkthrough

This change removes the TestSantacoder test class from the integration test suite and all related references. The removal includes the test class definition with its auto dtype test method, along with corresponding entries in test configuration and waiver files.

Changes

Cohort / File(s) Summary
Test Class Removal
tests/integration/defs/accuracy/test_cli_flow.py
Removed TestSantacoder class inheriting from CliFlowAccuracyTestHarness, including model metadata constants (MODEL_NAME, MODEL_PATH, EXAMPLE_FOLDER) and the test_auto_dtype() method.
Test Configuration Updates
tests/integration/test_lists/test-db/l0_gh200.yml, tests/integration/test_lists/waives.txt
Removed corresponding test references from the H200/TensorRT integration test list and waiver entry (SKIP status under nvbugs/5940463).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely a template with no actual content filled in; all sections are empty or contain only comments, providing no explanation of the changes, rationale, or test coverage. Add a description explaining why TestSantacoder test case was removed, reference the NVBugs issue details, and confirm the test coverage implications of removing this test.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing the TestSantacoder test case from test_cli_flow.py, with a proper NVBugs reference and fix type annotation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42336 [ run ] triggered by Bot. Commit: 8e6e083 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42336 [ run ] completed with state SUCCESS. Commit: 8e6e083
/LLM/main/L0_MergeRequest_PR pipeline #33124 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@QiJune
Copy link
Copy Markdown
Collaborator Author

QiJune commented Apr 9, 2026

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42416 [ run ] triggered by Bot. Commit: 8e6e083 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42416 [ run ] completed with state SUCCESS. Commit: 8e6e083
/LLM/main/L0_MergeRequest_PR pipeline #33186 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@QiJune
Copy link
Copy Markdown
Collaborator Author

QiJune commented Apr 9, 2026

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42512 [ run ] triggered by Bot. Commit: 8e6e083 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42512 [ run ] completed with state SUCCESS. Commit: 8e6e083
/LLM/main/L0_MergeRequest_PR pipeline #33256 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@QiJune
Copy link
Copy Markdown
Collaborator Author

QiJune commented Apr 10, 2026

/bot run

@QiJune QiJune enabled auto-merge (squash) April 10, 2026 07:10
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42685 [ run ] triggered by Bot. Commit: 8e6e083 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42685 [ run ] completed with state SUCCESS. Commit: 8e6e083
/LLM/main/L0_MergeRequest_PR pipeline #33384 completed with status: 'SUCCESS'

CI Report

Link to invocation

@QiJune QiJune merged commit b0f352d into NVIDIA:main Apr 10, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants