Skip to content

[None][chore] Waive failing pre-merge test#12916

Merged
brb-nv merged 1 commit intoNVIDIA:mainfrom
brb-nv:user/brb/waive-gpt-oss-harmony
Apr 10, 2026
Merged

[None][chore] Waive failing pre-merge test#12916
brb-nv merged 1 commit intoNVIDIA:mainfrom
brb-nv:user/brb/waive-gpt-oss-harmony

Conversation

@brb-nv
Copy link
Copy Markdown
Collaborator

@brb-nv brb-nv commented Apr 10, 2026

Description

Waive failing pre-merge test.

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

Release Notes

  • Tests
    • Added a test waiver to skip evaluation of a specific model configuration, referenced with a known issue tracking ID.

Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
@brb-nv
Copy link
Copy Markdown
Collaborator Author

brb-nv commented Apr 10, 2026

/bot skip --comment "Waive test failing in pre-merge"

@brb-nv brb-nv requested a review from ZhanruiSunCh April 10, 2026 05:15
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1897f29a-ef29-4d41-ae5a-210f8baacc37

📥 Commits

Reviewing files that changed from the base of the PR and between 62885f6 and 50e6d72.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Added a single entry to the test waives list that skips a specific test case for gpt-oss-120b with reference to bug nvbugs/6011317. No existing skip entries were modified.

Changes

Cohort / File(s) Summary
Test Skip List
tests/integration/test_lists/waives.txt
Added skip entry for disaggregated/test_disaggregated.py::test_disaggregated_gpt_oss_120b_harmony[gpt_oss/gpt-oss-120b] test case, annotated with bug reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: waiving a failing pre-merge test by adding an entry to the waives list.
Description check ✅ Passed The description is minimal but adequate for a waiver change. It identifies the purpose clearly, though it lacks specific details about which test is being waived.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@brb-nv brb-nv enabled auto-merge (squash) April 10, 2026 05:18
@brb-nv
Copy link
Copy Markdown
Collaborator Author

brb-nv commented Apr 10, 2026

/bot skip --comment "unblock pre-merge"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42668 [ skip ] triggered by Bot. Commit: 50e6d72 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42672 [ skip ] triggered by Bot. Commit: 50e6d72 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42668 [ skip ] completed with state ABORTED. Commit: 50e6d72

Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42672 [ skip ] completed with state SUCCESS. Commit: 50e6d72
Skipping testing for commit 50e6d72

Link to invocation

@brb-nv brb-nv merged commit 8a9ce02 into NVIDIA:main Apr 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants