[None][infra] Fix plc nightly pipeline and show more data#12940
Conversation
Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
|
/bot skip --comment "No need to run CI" |
📝 WalkthroughWalkthroughThree files are updated to refactor the vulnerability scanning pipeline: a function is renamed from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
jenkins/scripts/pulse_in_pipeline_scanning/submit_report.py (1)
175-177: Consider consistent fallback handling for new fields.
s_package_fix_versionusesor "N/A"as a fallback, buts_cve_urlwill beNoneif theurlfield is missing. This inconsistency may be intentional (URLs shouldn't be "N/A"), but if uniform handling is preferred:♻️ Optional: Add fallback for URL field
"s_package_fix_version": v.get("fix") or "N/A", "s_cve": v.get("vuln"), - "s_cve_url": v.get("url"), + "s_cve_url": v.get("url") or "",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@jenkins/scripts/pulse_in_pipeline_scanning/submit_report.py` around lines 175 - 177, The dict construction is inconsistent: s_package_fix_version uses a fallback (v.get("fix") or "N/A") while s_cve_url uses v.get("url") which may be None; update the code that builds the report entry (the dict using keys s_package_fix_version and s_cve_url) to apply a consistent fallback for the URL as well (e.g., use v.get("url") or "N/A" or an empty string), referencing the same variable v and the keys s_cve_url and s_package_fix_version so the field handling is uniform.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@jenkins/scripts/pulse_in_pipeline_scanning/submit_report.py`:
- Around line 175-177: The dict construction is inconsistent:
s_package_fix_version uses a fallback (v.get("fix") or "N/A") while s_cve_url
uses v.get("url") which may be None; update the code that builds the report
entry (the dict using keys s_package_fix_version and s_cve_url) to apply a
consistent fallback for the URL as well (e.g., use v.get("url") or "N/A" or an
empty string), referencing the same variable v and the keys s_cve_url and
s_package_fix_version so the field handling is uniform.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 28c4d4dc-d691-4f56-a54b-f66d19983c87
📒 Files selected for processing (3)
jenkins/TensorRT_LLM_PLC.groovyjenkins/scripts/pulse_in_pipeline_scanning/submit_report.pyjenkins/scripts/pulse_in_pipeline_scanning/utils/report.py
|
PR_Github #42740 [ skip ] triggered by Bot. Commit: |
|
PR_Github #42740 [ skip ] completed with state |
Summary by CodeRabbit
Description
Fix package name not showing up for container license report
Add fix version and CVE url to container vulnerability report in ES
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.