[None][test] Fix DGX_B200 CI timeout by splitting multimodal tests an…#12978
[None][test] Fix DGX_B200 CI timeout by splitting multimodal tests an…#12978nv-guomingz merged 1 commit intoNVIDIA:mainfrom
Conversation
|
/bot run |
📝 WalkthroughWalkthroughUpdated test metadata across two configuration files: recorded revised duration measurements for additional unit/integration tests, and enumerated specific multimodal test files instead of broad directory references in the l0_b200 test suite. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/integration/defs/.test_durations`:
- Around line 805-806: The .test_durations file is missing entries for the
remaining test_moe_backend selectors (CUTEDSL, DEEPGEMM, DENSEGEMM) which skews
pytest-split balancing; add keys matching the existing pattern used for
CUTLASS/TRTLLM such as
"test_unittests.py::test_unittests_v2[unittest/_torch/modules/moe/test_moe_backend.py::test_moe_backend
-k \"CUTEDSL\"]",
"test_unittests.py::test_unittests_v2[unittest/_torch/modules/moe/test_moe_backend.py::test_moe_backend
-k \"DEEPGEMM\"]", and
"test_unittests.py::test_unittests_v2[unittest/_torch/modules/moe/test_moe_backend.py::test_moe_backend
-k \"DENSEGEMM\"]" with reasonable duration values (estimate based on
CUTLASS/TRTLLM or other similar tests) so pytest-split can balance shards
correctly. Ensure the key formatting exactly matches the existing entries
(module path, test name, and -k selector) and commit the updated .test_durations
entry to keep split/timeouts accurate.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 024246b5-b89d-4e3e-8640-961a8612f561
📒 Files selected for processing (2)
tests/integration/defs/.test_durationstests/integration/test_lists/test-db/l0_b200.yml
|
PR_Github #42944 [ run ] triggered by Bot. Commit: |
nv-guomingz
force-pushed
the
user/guomingz/opt_test
branch
from
cb38fa5 to
845b19e
Compare
|
PR_Github #42944 [ run ] completed with state
|
|
/bot run |
|
PR_Github #42978 [ run ] triggered by Bot. Commit: |
|
PR_Github #42978 [ run ] completed with state
|
|
/bot run |
|
PR_Github #43015 [ run ] triggered by Bot. Commit: |
|
PR_Github #43015 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #43056 [ run ] triggered by Bot. Commit: |
|
PR_Github #43056 [ run ] completed with state
|
|
/bot run |
|
PR_Github #43138 [ run ] triggered by Bot. Commit: |
|
PR_Github #43138 [ run ] completed with state
|
nv-guomingz
force-pushed
the
user/guomingz/opt_test
branch
from
845b19e to
33e864a
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #43623 [ run ] triggered by Bot. Commit: |
|
PR_Github #43623 [ run ] completed with state
|
|
/bot run |
|
PR_Github #43777 [ run ] triggered by Bot. Commit: |
|
PR_Github #43777 [ run ] completed with state
|
|
/bot run |
|
PR_Github #43891 [ run ] triggered by Bot. Commit: |
|
PR_Github #43891 [ run ] completed with state
|
|
/bot run |
Pull request was closed
|
PR_Github #43932 [ ] completed with state |
…d correcting stale/missing test durations for pytest-split. Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
|
/bot run |
nv-guomingz
force-pushed
the
user/guomingz/opt_test
branch
from
33e864a to
583f6f7
Compare
|
PR_Github #44116 [ run ] triggered by Bot. Commit: |
|
PR_Github #44116 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #44267 [ run ] triggered by Bot. Commit: |
|
PR_Github #44267 [ run ] completed with state
|
|
/bot run |
|
PR_Github #44438 [ run ] triggered by Bot. Commit: |
|
PR_Github #44438 [ run ] completed with state |
3 participants
…d correcting stale/missing test durations for pytest-split.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.