Skip to content

[https://nvbugs/5846024][fix] Remove waivers#12979

Merged
VALLIS-NERIA merged 1 commit intoNVIDIA:mainfrom
VALLIS-NERIA:VALLIS-NERIA-patch-3
Apr 15, 2026
Merged

[https://nvbugs/5846024][fix] Remove waivers#12979
VALLIS-NERIA merged 1 commit intoNVIDIA:mainfrom
VALLIS-NERIA:VALLIS-NERIA-patch-3

Conversation

@VALLIS-NERIA
Copy link
Copy Markdown
Collaborator

@VALLIS-NERIA VALLIS-NERIA commented Apr 13, 2026

Summary by CodeRabbit

  • Tests
    • Removed one test waiver entry from internal test configuration, allowing a previously excluded test case to be validated.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: xiweny <13230610+VALLIS-NERIA@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a2a85577-f9c3-4923-9434-ef6c5b28fb04

📥 Commits

Reviewing files that changed from the base of the PR and between ae84aad and 5b47800.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This pull request removes a single waiver entry for a test from the test configuration list, allowing the previously skipped test case to run. The change affects only the test waiver list file with no functional code modifications.

Changes

Cohort / File(s) Summary
Test Waiver Configuration
tests/integration/test_lists/waives.txt
Removed waiver entry for accuracy/test_llm_api_pytorch.py::TestDeepSeekR1::test_fp8_blockscale[latency] test case that was previously marked as SKIP.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely empty—only the template structure remains with no actual content in required sections like Description, Test Coverage, or Checklist completion. Provide a clear description explaining why the waiver was removed, list relevant test coverage, and complete the PR checklist as appropriate.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly follows the required format with ticket reference and type, and accurately describes the main change: removing a waiver entry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@VALLIS-NERIA
Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "DGX_H200-8_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42945 [ run ] triggered by Bot. Commit: 5b47800 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42945 [ run ] completed with state SUCCESS. Commit: 5b47800
/LLM/main/L0_MergeRequest_PR pipeline #33603 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@VALLIS-NERIA
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "the stage containing the test has succeeded"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43495 [ skip ] triggered by Bot. Commit: 5b47800 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43495 [ skip ] completed with state SUCCESS. Commit: 5b47800
Skipping testing for commit 5b47800

Link to invocation

@VALLIS-NERIA VALLIS-NERIA enabled auto-merge (squash) April 15, 2026 13:58
@VALLIS-NERIA VALLIS-NERIA merged commit f2c3dac into NVIDIA:main Apr 15, 2026
6 of 8 checks passed
chienchunhung pushed a commit to chienchunhung/TensorRT-LLM that referenced this pull request Apr 16, 2026
Signed-off-by: xiweny <13230610+VALLIS-NERIA@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants