[https://nvbugs/5626259][fix] Enable nemotron-h chunk prefill test#12980
[https://nvbugs/5626259][fix] Enable nemotron-h chunk prefill test#12980Wanli-Jiang merged 1 commit intoNVIDIA:mainfrom
Conversation
c1c0402 to
e4a276b
Compare
|
/bot run --disable-fail-fast |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughA unit test for Nemotron-H chunked prefill functionality is re-enabled by removing a skip decorator. Within the test, an assertion comparing generated text output is removed while retaining numerical logprob comparisons. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #42956 [ run ] triggered by Bot. Commit: |
|
PR_Github #42956 [ run ] completed with state
|
509c786 to
5a377fb
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #43194 [ run ] triggered by Bot. Commit: |
|
PR_Github #43194 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #43235 [ run ] triggered by Bot. Commit: |
|
PR_Github #43235 [ run ] completed with state |
5a377fb to
7264bf8
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #43407 [ run ] triggered by Bot. Commit: |
|
PR_Github #43407 [ run ] completed with state
|
* Enable nemotron-h chunk prefill smoke test in https://nvbugs/5626259 * Unwaive test in https://nvbugs/5959992 Signed-off-by: Wanli Jiang <35160485+Wanli-Jiang@users.noreply.github.com>
7264bf8 to
dfb76d4
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #43608 [ run ] triggered by Bot. Commit: |
|
PR_Github #43608 [ run ] completed with state
|
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot run --only-multi-gpu-test --disable-fail-fast |
|
PR_Github #43693 [ run ] triggered by Bot. Commit: |
|
PR_Github #43693 [ run ] completed with state
|
|
/bot skip --comment "the re-enable tests are passed" |
|
PR_Github #43896 [ skip ] triggered by Bot. Commit: |
|
PR_Github #43896 [ skip ] completed with state |
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.