Skip to content

[https://nvbugs/6061812][fix] Unblock ruff check#12996

Merged
VALLIS-NERIA merged 1 commit intoNVIDIA:mainfrom
VALLIS-NERIA:fix_release_check
Apr 13, 2026
Merged

[https://nvbugs/6061812][fix] Unblock ruff check#12996
VALLIS-NERIA merged 1 commit intoNVIDIA:mainfrom
VALLIS-NERIA:fix_release_check

Conversation

@VALLIS-NERIA
Copy link
Copy Markdown
Collaborator

@VALLIS-NERIA VALLIS-NERIA commented Apr 13, 2026

Summary by CodeRabbit

  • Tests
    • Streamlined test documentation formatting for improved readability.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Xiwen Yu <13230610+VALLIS-NERIA@users.noreply.github.com>
@VALLIS-NERIA
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "comments only, run release-check"

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 13, 2026

📝 Walkthrough

Walkthrough

Test file docstrings in test_executor.py are reformatted, collapsing multi-line explanatory strings into single-line sentences for four test methods. No functional changes or logic modifications are included.

Changes

Cohort / File(s) Summary
Test Docstring Formatting
tests/unittest/llmapi/test_executor.py
Reformatted docstrings for four test methods (test_abort_on_DetokenizedGenerationResultBase, test_PostprocWorker_Output_should_abort, test_handle_response_propagates_should_abort, test_get_params_for_first_rsp_returns_disaggregated_params_once) by collapsing multi-line descriptions into single-line sentences with equivalent meaning.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely a template with no actual content filled in. All substantive sections (Description, Test Coverage) are empty. Fill in the Description section explaining the changes made to test docstrings. Complete Test Coverage section listing affected tests. Verify PR Checklist items match the minimal nature of docstring formatting changes.
Title check ⚠️ Warning The title references fixing a ruff check issue, but the changeset only contains trivial docstring reformatting with no actual fixes to ruff checks or code logic. Update the title to accurately reflect the actual change: reformatting test docstrings to be single-line, such as 'Reformat test docstrings to single-line format' or 'Clean up test docstring formatting'.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@VALLIS-NERIA VALLIS-NERIA changed the title [http://nvbugs/6061812][fix] Unblock ruff check [https://nvbugs/6061812][fix] Unblock ruff check Apr 13, 2026
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43019 [ skip ] triggered by Bot. Commit: 2184c26 Link to invocation

Copy link
Copy Markdown
Collaborator

@mzweilz mzweilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43019 [ skip ] completed with state SUCCESS. Commit: 2184c26
Skipping testing for commit 2184c26

Link to invocation

@VALLIS-NERIA VALLIS-NERIA merged commit 67b754e into NVIDIA:main Apr 13, 2026
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants