Skip to content

[None][test] Waive two dsv3lite cases due to nvbug 6071081.#13001

Merged
nv-guomingz merged 1 commit intoNVIDIA:mainfrom
nv-guomingz:user/guomingz/waive_issue_6071081
Apr 13, 2026
Merged

[None][test] Waive two dsv3lite cases due to nvbug 6071081.#13001
nv-guomingz merged 1 commit intoNVIDIA:mainfrom
nv-guomingz:user/guomingz/waive_issue_6071081

Conversation

@nv-guomingz
Copy link
Copy Markdown
Collaborator

@nv-guomingz nv-guomingz commented Apr 13, 2026

Summary by CodeRabbit

  • Tests
    • Updated test waivers for specific GPU configuration combinations.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 13, 2026

📝 Walkthrough

Walkthrough

Two SKIP waiver entries were added to the test waiver list for DeepSeekV3Lite accuracy tests. Each entry specifies a different test parameter combination and references the same NVIDIA bugs ticket for tracking.

Changes

Cohort / File(s) Summary
Test Waiver Configuration
tests/integration/test_lists/waives.txt
Added two SKIP entries for TestDeepSeekV3Lite accuracy tests with distinct parameter configurations (test_nvfp4 and test_bfloat16_python_scheduler), both linked to the same tracking ticket.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • EmmaQiaoCh
  • yuxianq
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is empty and does not provide any explanation of the changes. All sections (Description, Test Coverage) are blank, and only the template checklist is present without addressing the actual changes made. Add a clear description explaining why these two test cases are being waived for the DeepSeekV3Lite model and reference NVBug 6071081. Also specify any relevant test coverage information.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding two test waivers for dsv3lite cases linked to nvbug 6071081.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 348: The waiver entry for TestDeepSeekV3Lite::test_nvfp4 is missing the
parameterized moe_backend value, so the pytest node id is likely mismatched and
the waiver becomes a no-op; update the waiver line in
tests/integration/test_lists/waives.txt to include the full parameter set
including moe_backend (e.g., moe_backend=CUTLASS) so the node id exactly matches
the parameterized test TestDeepSeekV3Lite::test_nvfp4.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f5b3e438-2d05-4112-b9ef-be780c76277d

📥 Commits

Reviewing files that changed from the base of the PR and between 3605638 and 30b0c56.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Comment thread tests/integration/test_lists/waives.txt
@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "update waives.txt only"

@nv-guomingz nv-guomingz enabled auto-merge (squash) April 13, 2026 13:57
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43052 [ skip ] triggered by Bot. Commit: 30b0c56 Link to invocation

@nv-guomingz nv-guomingz disabled auto-merge April 13, 2026 14:02
@nv-guomingz nv-guomingz merged commit 11716e0 into NVIDIA:main Apr 13, 2026
7 of 10 checks passed
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43052 [ skip ] completed with state SUCCESS. Commit: 30b0c56
Skipping testing for commit 30b0c56

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants