[None][test] Waive two dsv3lite cases due to nvbug 6071081.#13001
[None][test] Waive two dsv3lite cases due to nvbug 6071081.#13001nv-guomingz merged 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
📝 WalkthroughWalkthroughTwo SKIP waiver entries were added to the test waiver list for DeepSeekV3Lite accuracy tests. Each entry specifies a different test parameter combination and references the same NVIDIA bugs ticket for tracking. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 348: The waiver entry for TestDeepSeekV3Lite::test_nvfp4 is missing the
parameterized moe_backend value, so the pytest node id is likely mismatched and
the waiver becomes a no-op; update the waiver line in
tests/integration/test_lists/waives.txt to include the full parameter set
including moe_backend (e.g., moe_backend=CUTLASS) so the node id exactly matches
the parameterized test TestDeepSeekV3Lite::test_nvfp4.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: f5b3e438-2d05-4112-b9ef-be780c76277d
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
/bot skip --comment "update waives.txt only" |
|
PR_Github #43052 [ skip ] triggered by Bot. Commit: |
|
PR_Github #43052 [ skip ] completed with state |
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.