Skip to content

[None][infra] Remove invalid test case in waive list#13008

Merged
yuanjingx87 merged 1 commit intoNVIDIA:mainfrom
yuanjingx87:user/yuanjingx/waive_list_fix
Apr 13, 2026
Merged

[None][infra] Remove invalid test case in waive list#13008
yuanjingx87 merged 1 commit intoNVIDIA:mainfrom
yuanjingx87:user/yuanjingx/waive_list_fix

Conversation

@yuanjingx87
Copy link
Copy Markdown
Collaborator

@yuanjingx87 yuanjingx87 commented Apr 13, 2026

Summary by CodeRabbit

  • Tests
    • Re-enabled a previously skipped test case to improve test coverage and ensure more comprehensive validation of the codebase across different configurations.

Description

remove invalid test case in waive list

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
@yuanjingx87
Copy link
Copy Markdown
Collaborator Author

/bot run

Copy link
Copy Markdown
Collaborator

@brb-nv brb-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8108b25b-2ebe-4428-809d-67975e94181e

📥 Commits

Reviewing files that changed from the base of the PR and between fc2ba32 and f0a4201.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A single test case entry was removed from the test waives list, meaning the parametrized test case for DeepSeekV3Lite's NVFP4 configuration is no longer excluded and will now run during test execution.

Changes

Cohort / File(s) Summary
Test Waives Configuration
tests/integration/test_lists/waives.txt
Removed one waived test entry for TestDeepSeekV3Lite::test_nvfp4 with specific parameters, re-enabling the test case.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is mostly incomplete. While a brief description 'remove invalid test case in waive list' is provided, critical sections like 'Test Coverage' and detailed 'Description' are missing or empty. Expand the description section to explain what made the test case invalid and why it should be removed; add test coverage details or clarify if N/A for this waive list change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing an invalid test case from the waive list, which is exactly what the changeset accomplishes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43094 [ run ] triggered by Bot. Commit: f0a4201 Link to invocation

@yuanjingx87
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Check Waive List passed is sufficient"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43101 [ skip ] triggered by Bot. Commit: f0a4201 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43101 [ skip ] completed with state SUCCESS. Commit: f0a4201
Skipping testing for commit f0a4201

Link to invocation

@yuanjingx87 yuanjingx87 merged commit 4ae49e1 into NVIDIA:main Apr 13, 2026
9 of 10 checks passed
chienchunhung pushed a commit to chienchunhung/TensorRT-LLM that referenced this pull request Apr 16, 2026
Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants