Skip to content

[None][chore] Unwaive broader test lists#13053

Merged
brb-nv merged 1 commit intoNVIDIA:mainfrom
brb-nv:user/brb/unwaive-broad-test-waives
Apr 14, 2026
Merged

[None][chore] Unwaive broader test lists#13053
brb-nv merged 1 commit intoNVIDIA:mainfrom
brb-nv:user/brb/unwaive-broad-test-waives

Conversation

@brb-nv
Copy link
Copy Markdown
Collaborator

@brb-nv brb-nv commented Apr 14, 2026

Description

Unwaive broader test lists.

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

Tests

  • Re-enabled previously excluded deep learning model training test cases (parts 2 and 3) and GPU deployment transformation tests. These components are now actively validated as part of the standard test suite to ensure proper system functionality.

Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dc73d185-56f9-489f-a68f-f60f32e01dbf

📥 Commits

Reviewing files that changed from the base of the PR and between 2335ef8 and 62965b7.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Three test skip entries were removed from the test waive list file, enabling the unskipped test cases (unittest/llmapi/test_llm_pytorch.py part2 and part3, and unittest/auto_deploy/singlegpu/transformations) to execute during test runs.

Changes

Cohort / File(s) Summary
Test Skip List
tests/integration/test_lists/waives.txt
Removed three SKIP entries, unskipping tests for LLM PyTorch part2/part3 and single GPU transformations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][chore] Unwaive broader test lists' clearly and concisely summarizes the main change: removing waive entries from the test list file.
Description check ✅ Passed The description provides a brief explanation of the change and includes the PR checklist; while minimal, it adequately describes the purpose and satisfies template requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@brb-nv
Copy link
Copy Markdown
Collaborator Author

brb-nv commented Apr 14, 2026

/bot skip --comment "Bring back broader testlists waived by mistake"

@Tabrizian
Copy link
Copy Markdown
Member

/bot skip --comment "CI waiving"

@brb-nv brb-nv enabled auto-merge (squash) April 14, 2026 23:02
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43294 [ skip ] triggered by Bot. Commit: 62965b7 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43295 [ skip ] triggered by Bot. Commit: 62965b7 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43294 [ skip ] completed with state ABORTED. Commit: 62965b7

Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43295 [ skip ] completed with state SUCCESS. Commit: 62965b7
Skipping testing for commit 62965b7

Link to invocation

@brb-nv brb-nv merged commit f7782cb into NVIDIA:main Apr 14, 2026
8 checks passed
chienchunhung pushed a commit to chienchunhung/TensorRT-LLM that referenced this pull request Apr 16, 2026
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants