Skip to content

[None][chore] Update waived test name#13058

Merged
yiqingy0 merged 1 commit intoNVIDIA:mainfrom
brb-nv:user/brb/update-bad-waive
Apr 15, 2026
Merged

[None][chore] Update waived test name#13058
yiqingy0 merged 1 commit intoNVIDIA:mainfrom
brb-nv:user/brb/update-bad-waive

Conversation

@brb-nv
Copy link
Copy Markdown
Collaborator

@brb-nv brb-nv commented Apr 15, 2026

Description

Update waived test name.

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

  • Chores
    • Updated internal test infrastructure configuration for model testing validation.

Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b6a0e610-f7ab-4041-bf8f-d8dd9270efb3

📥 Commits

Reviewing files that changed from the base of the PR and between f7782cb and 1cffd09.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Updated a test waive entry in the waives file to replace a pytest directory selection with a direct test node reference for the Starcoder2 multi-LoRA test, maintaining the same skip rationale and URL.

Changes

Cohort / File(s) Summary
Test Waive List
tests/integration/test_lists/waives.txt
Updated waive entry for Starcoder2 multi-LoRA test from directory-based pytest selection to direct test node path reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating a waived test name in the test configuration file.
Description check ✅ Passed The description is minimal but appropriately brief for a chore task that updates a waive-list entry with no functional code changes or test coverage needed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@brb-nv
Copy link
Copy Markdown
Collaborator Author

brb-nv commented Apr 15, 2026

/bot run

@brb-nv
Copy link
Copy Markdown
Collaborator Author

brb-nv commented Apr 15, 2026

/bot run --skip-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43336 [ run ] triggered by Bot. Commit: 1cffd09 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43338 [ run ] triggered by Bot. Commit: 1cffd09 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43336 [ run ] completed with state ABORTED. Commit: 1cffd09

Link to invocation

@yiqingy0
Copy link
Copy Markdown
Collaborator

/bot skip --comment "passed the check Test List stage"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43338 [ run ] completed with state FAILURE. Commit: 1cffd09
/LLM/main/L0_MergeRequest_PR pipeline #33879 (Partly Tested) completed with status: 'ABORTED'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43352 [ skip ] triggered by Bot. Commit: 1cffd09 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43352 [ skip ] completed with state SUCCESS. Commit: 1cffd09
Skipping testing for commit 1cffd09

Link to invocation

@yiqingy0 yiqingy0 merged commit d09ed1e into NVIDIA:main Apr 15, 2026
8 checks passed
chienchunhung pushed a commit to chienchunhung/TensorRT-LLM that referenced this pull request Apr 16, 2026
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants