Skip to content

[None][fix] Pin Ray version to 2.54.1 in slurm CI stage#13085

Merged
brb-nv merged 2 commits intoNVIDIA:mainfrom
shuyixiong:user/shuyix/pin_ray_version1
Apr 15, 2026
Merged

[None][fix] Pin Ray version to 2.54.1 in slurm CI stage#13085
brb-nv merged 2 commits intoNVIDIA:mainfrom
shuyixiong:user/shuyix/pin_ray_version1

Conversation

@shuyixiong
Copy link
Copy Markdown
Collaborator

@shuyixiong shuyixiong commented Apr 15, 2026

Summary by CodeRabbit

  • Chores
    • Pinned a dependency version to ensure stable and consistent build environments during testing.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Shuyi Xiong <219646547+shuyixiong@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 14403d44-e945-447b-9f94-ca9cf9e8ea90

📥 Commits

Reviewing files that changed from the base of the PR and between 67fde60 and 444f212.

📒 Files selected for processing (1)
  • jenkins/scripts/slurm_install.sh

📝 Walkthrough

Walkthrough

Updated the Ray installation command in jenkins/scripts/slurm_install.sh to pin the ray[default] dependency to exact version 2.54.1 when the pytest command includes --run-ray* flags, changing from an unversioned to versioned dependency specification.

Changes

Cohort / File(s) Summary
Ray Dependency Pinning
jenkins/scripts/slurm_install.sh
Pinned ray[default] to exact version 2.54.1 in the conditional Ray installation step within the slurm_install_setup() function.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • yuanjingx87
  • venkywonka
🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely composed of the template with no actual content provided in the Description, Test Coverage, or explanatory sections. Fill in the Description section explaining why Ray version needs to be pinned, and provide Test Coverage details showing how the change is validated.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly specifies the main change: pinning Ray version to 2.54.1 in the slurm CI stage, which directly matches the changeset modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@shuyixiong shuyixiong requested a review from a team as a code owner April 15, 2026 14:49
Signed-off-by: Shuyi Xiong <219646547+shuyixiong@users.noreply.github.com>
@shuyixiong shuyixiong force-pushed the user/shuyix/pin_ray_version1 branch from c736fa0 to 5dafccf Compare April 15, 2026 14:51
@shuyixiong
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Pin Ray version to 2.54.1 in slurm CI stage"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43519 [ skip ] triggered by Bot. Commit: 5dafccf Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43519 [ skip ] completed with state SUCCESS. Commit: 5dafccf
Skipping testing for commit 5dafccf

Link to invocation

Copy link
Copy Markdown
Collaborator

@brb-nv brb-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brb-nv brb-nv merged commit 51f7956 into NVIDIA:main Apr 15, 2026
5 checks passed
yuanjingx87 pushed a commit to yuanjingx87/TensorRT-LLM that referenced this pull request Apr 15, 2026
Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
chienchunhung pushed a commit to chienchunhung/TensorRT-LLM that referenced this pull request Apr 16, 2026
Signed-off-by: Shuyi Xiong <219646547+shuyixiong@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants