[None][fix] Update stale TOKENIZER_ALIASES import path in serve and bench modules by cascade812 · Pull Request #13086 · NVIDIA/TensorRT-LLM

cascade812 · 2026-04-15T17:08:51Z

Summary by CodeRabbit

Refactor
- Reorganized internal tokenizer alias import sources across modules for improved code structure.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…ench modules Signed-off-by: Guiju Zhang <7135567+cascade812@users.noreply.github.com>

cascade812 · 2026-04-15T17:09:38Z

/bot run

coderabbitai · 2026-04-15T17:12:07Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 483b3ca3-62df-432d-842a-50c7eeb15d7c

📥 Commits

Reviewing files that changed from the base of the PR and between 50717eb and 9669c8a.

📒 Files selected for processing (2)

tensorrt_llm/bench/utils/data.py
tensorrt_llm/serve/scripts/backend_request_func.py

📝 Walkthrough

Walkthrough

Updated import source of TOKENIZER_ALIASES from tensorrt_llm.llmapi.llm_args to tensorrt_llm.tokenizer in two utility functions handling tokenizer initialization and retrieval, without changing control flow or behavior.

Changes

Cohort / File(s)	Summary
Tokenizer Aliases Import Relocation `tensorrt_llm/bench/utils/data.py`, `tensorrt_llm/serve/scripts/backend_request_func.py`	Relocated import source of `TOKENIZER_ALIASES` from `tensorrt_llm.llmapi.llm_args` to `tensorrt_llm.tokenizer` in `initialize_tokenizer` and `get_tokenizer` functions respectively.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is completely empty of substantive content—it only contains the template structure with unfilled placeholder sections and no actual Description, Test Coverage, or implementation details provided by the author.	Fill in the Description section explaining what the stale import issue was and why it was fixed; provide Test Coverage details on which tests safeguard this change; and complete the PR Checklist items appropriately.
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the specific change: updating a stale import path for TOKENIZER_ALIASES in serve and bench modules, which matches the code modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2026-04-15T17:15:34Z

PR_Github #43548 [ run ] triggered by Bot. Commit: 9669c8a Link to invocation

tensorrt-cicd · 2026-04-15T19:20:18Z

PR_Github #43548 [ run ] completed with state SUCCESS. Commit: 9669c8a
/LLM/main/L0_MergeRequest_PR pipeline #34052 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

cascade812 · 2026-04-15T20:07:33Z

/bot run

tensorrt-cicd · 2026-04-15T20:13:52Z

PR_Github #43575 [ run ] triggered by Bot. Commit: 9669c8a Link to invocation

tensorrt-cicd · 2026-04-15T22:40:24Z

PR_Github #43575 [ run ] completed with state SUCCESS. Commit: 9669c8a
/LLM/main/L0_MergeRequest_PR pipeline #34072 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

cascade812 · 2026-04-15T23:57:46Z

/bot run

tensorrt-cicd · 2026-04-16T00:04:30Z

PR_Github #43587 [ run ] triggered by Bot. Commit: 9669c8a Link to invocation

tensorrt-cicd · 2026-04-16T03:14:34Z

PR_Github #43587 [ run ] completed with state FAILURE. Commit: 9669c8a
/LLM/main/L0_MergeRequest_PR pipeline #34081 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

cascade812 · 2026-04-16T16:47:50Z

/bot run

tensorrt-cicd · 2026-04-16T16:54:52Z

PR_Github #43815 [ run ] triggered by Bot. Commit: 9669c8a Link to invocation

tensorrt-cicd · 2026-04-17T00:23:17Z

PR_Github #43815 [ run ] completed with state FAILURE. Commit: 9669c8a
/LLM/main/L0_MergeRequest_PR pipeline #34288 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

cascade812 · 2026-04-17T00:28:38Z

/bot run

tensorrt-cicd · 2026-04-17T00:34:19Z

PR_Github #43857 [ run ] triggered by Bot. Commit: 9669c8a Link to invocation

cascade812 · 2026-04-17T00:34:36Z

/bot run

tensorrt-cicd · 2026-04-17T00:40:16Z

PR_Github #43859 [ run ] triggered by Bot. Commit: 9669c8a Link to invocation

tensorrt-cicd · 2026-04-17T00:40:20Z

PR_Github #43857 [ run ] completed with state ABORTED. Commit: 9669c8a

Link to invocation

tensorrt-cicd · 2026-04-17T00:44:24Z

PR_Github #43859 [ run ] completed with state FAILURE. Commit: 9669c8a

Link to invocation

cascade812 · 2026-04-17T00:58:41Z

/bot run

tensorrt-cicd · 2026-04-17T01:05:31Z

PR_Github #43864 [ run ] triggered by Bot. Commit: 9669c8a Link to invocation

tensorrt-cicd · 2026-04-17T02:46:51Z

PR_Github #43864 [ run ] completed with state FAILURE. Commit: 9669c8a
/LLM/main/L0_MergeRequest_PR pipeline #34317 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

cascade812 · 2026-04-17T02:48:47Z

/bot run

tensorrt-cicd · 2026-04-17T02:54:52Z

PR_Github #43903 [ run ] triggered by Bot. Commit: 9669c8a Link to invocation

tensorrt-cicd · 2026-04-17T03:08:50Z

PR_Github #43903 [ run ] completed with state FAILURE. Commit: 9669c8a
/LLM/main/L0_MergeRequest_PR pipeline #34354 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

cascade812 · 2026-04-17T03:18:50Z

/bot run

tensorrt-cicd · 2026-04-17T03:24:35Z

PR_Github #43923 [ run ] triggered by Bot. Commit: 9669c8a Link to invocation

tensorrt-cicd · 2026-04-17T03:54:20Z

PR_Github #43923 [ run ] completed with state FAILURE. Commit: 9669c8a
/LLM/main/L0_MergeRequest_PR pipeline #34371 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

cascade812 · 2026-04-17T03:58:53Z

/bot run

tensorrt-cicd · 2026-04-17T04:05:05Z

PR_Github #43946 [ run ] triggered by Bot. Commit: 9669c8a Link to invocation

cascade812 · 2026-04-17T04:48:24Z

/bot help

github-actions · 2026-04-17T04:48:32Z

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

cascade812 · 2026-04-17T04:49:47Z

/bot run

tensorrt-cicd · 2026-04-17T04:55:20Z

PR_Github #43952 [ run ] triggered by Bot. Commit: d8b841a Link to invocation

tensorrt-cicd · 2026-04-17T08:27:32Z

PR_Github #43952 [ run ] completed with state SUCCESS. Commit: d8b841a
/LLM/main/L0_MergeRequest_PR pipeline #34400 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

cascade812 · 2026-04-17T08:30:29Z

/bot run

tensorrt-cicd · 2026-04-17T08:38:33Z

PR_Github #44008 [ run ] triggered by Bot. Commit: d8b841a Link to invocation

tensorrt-cicd · 2026-04-17T09:47:56Z

PR_Github #44008 [ run ] completed with state FAILURE. Commit: d8b841a
/LLM/main/L0_MergeRequest_PR pipeline #34447 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

cascade812 · 2026-04-17T09:50:34Z

/bot run

tensorrt-cicd · 2026-04-17T09:56:15Z

PR_Github #44021 [ run ] triggered by Bot. Commit: d8b841a Link to invocation

tensorrt-cicd · 2026-04-17T13:22:22Z

PR_Github #44021 [ run ] completed with state SUCCESS. Commit: d8b841a
/LLM/main/L0_MergeRequest_PR pipeline #34461 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

cascade812 · 2026-04-17T13:30:43Z

/bot run

tensorrt-cicd · 2026-04-17T13:37:57Z

PR_Github #44036 [ run ] triggered by Bot. Commit: d8b841a Link to invocation

tensorrt-cicd · 2026-04-18T13:38:46Z

PR_Github #44036 [ run ] completed with state ABORTED. Commit: d8b841a

Link to invocation

cascade812 · 2026-04-18T17:32:06Z

/bot run

tensorrt-cicd · 2026-04-18T17:37:40Z

PR_Github #44130 [ run ] triggered by Bot. Commit: d8b841a Link to invocation

tensorrt-cicd · 2026-04-18T18:07:59Z

PR_Github #44130 [ run ] completed with state FAILURE. Commit: d8b841a
/LLM/main/L0_MergeRequest_PR pipeline #34558 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

cascade812 · 2026-04-18T18:13:30Z

/bot run

tensorrt-cicd · 2026-04-18T18:19:14Z

PR_Github #44132 [ run ] triggered by Bot. Commit: d8b841a Link to invocation

tensorrt-cicd · 2026-04-18T23:48:27Z

PR_Github #44132 [ run ] completed with state SUCCESS. Commit: d8b841a
/LLM/main/L0_MergeRequest_PR pipeline #34559 completed with status: 'SUCCESS'

CI Report

Link to invocation

[None][fix] Update stale TOKENIZER_ALIASES import path in serve and b…

9669c8a

…ench modules Signed-off-by: Guiju Zhang <7135567+cascade812@users.noreply.github.com>

cascade812 requested review from a team as code owners April 15, 2026 17:08

cascade812 requested a review from venkywonka April 15, 2026 17:08

github-actions Bot assigned cascade812 Apr 15, 2026

Merge branch 'main' into fix1

d8b841a

venkywonka approved these changes Apr 17, 2026

View reviewed changes

cascade812 enabled auto-merge (squash) April 17, 2026 17:38

cascade812 merged commit cb4c2bd into NVIDIA:main Apr 18, 2026
5 checks passed

Conversation

cascade812 commented Apr 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

Uh oh!

cascade812 commented Apr 15, 2026

Uh oh!

coderabbitai Bot commented Apr 15, 2026

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (2 warnings)

Uh oh!

tensorrt-cicd commented Apr 15, 2026

Uh oh!

tensorrt-cicd commented Apr 15, 2026

Uh oh!

cascade812 commented Apr 15, 2026

Uh oh!

tensorrt-cicd commented Apr 15, 2026

Uh oh!

tensorrt-cicd commented Apr 15, 2026

Uh oh!

cascade812 commented Apr 15, 2026

Uh oh!

tensorrt-cicd commented Apr 16, 2026

Uh oh!

tensorrt-cicd commented Apr 16, 2026

Uh oh!

cascade812 commented Apr 16, 2026

Uh oh!

tensorrt-cicd commented Apr 16, 2026

Uh oh!

tensorrt-cicd commented Apr 17, 2026

Uh oh!

cascade812 commented Apr 17, 2026

Uh oh!

tensorrt-cicd commented Apr 17, 2026

Uh oh!

cascade812 commented Apr 17, 2026

Uh oh!

tensorrt-cicd commented Apr 17, 2026

Uh oh!

tensorrt-cicd commented Apr 17, 2026

Uh oh!

tensorrt-cicd commented Apr 17, 2026

Uh oh!

cascade812 commented Apr 17, 2026

Uh oh!

tensorrt-cicd commented Apr 17, 2026

Uh oh!

tensorrt-cicd commented Apr 17, 2026

Uh oh!

cascade812 commented Apr 17, 2026

Uh oh!

tensorrt-cicd commented Apr 17, 2026

Uh oh!

tensorrt-cicd commented Apr 17, 2026

Uh oh!

cascade812 commented Apr 17, 2026

Uh oh!

tensorrt-cicd commented Apr 17, 2026

Uh oh!

tensorrt-cicd commented Apr 17, 2026

Uh oh!

cascade812 commented Apr 17, 2026

Uh oh!

tensorrt-cicd commented Apr 17, 2026

Uh oh!

cascade812 commented Apr 17, 2026

Uh oh!

github-actions Bot commented Apr 17, 2026

GitHub Bot Help

kill

skip

reuse-pipeline

cascade812 commented Apr 15, 2026 •

edited by coderabbitai Bot

Loading