[None][infra] Reenable GB300-4_GPUs-PyTorch-Post-Merge-1#13097
[None][infra] Reenable GB300-4_GPUs-PyTorch-Post-Merge-1#13097mlefeb01 merged 4 commits intoNVIDIA:mainfrom
Conversation
|
/bot run --disable-fail-fast --stage-list "GB300-4_GPUs-PyTorch-Post-Merge-1" |
📝 WalkthroughWalkthroughA test stage configuration entry in the Jenkins pipeline is modified to change its platform/cluster selector from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
jenkins/L0_Test.groovy (1)
2970-2972: Refresh the GB300 disablement comment to match the now-enabled stage.Line 2970 says GB300 stages are disabled, but Line 2972 re-enables one. Please update the comment to avoid operator confusion.
Suggested diff
- // Disable GB300 stages due to nodes will be offline temporarily. + // Keep some GB300 stages disabled while re-enabling selected post-merge coverage. // "GB300-PyTorch-1": ["gb300-single", "l0_gb300", 1, 1], "GB300-4_GPUs-PyTorch-Post-Merge-1": ["auto:gb300-flex", "l0_gb300_multi_gpus", 1, 1, 4],🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@jenkins/L0_Test.groovy` around lines 2970 - 2972, Update the misleading comment that says "Disable GB300 stages due to nodes will be offline temporarily." to reflect that the "GB300-4_GPUs-PyTorch-Post-Merge-1" stage is now enabled; locate the comment above the GB300 stage entries and change it to something like "Adjust GB300 stages: most disabled, GB300-4_GPUs-PyTorch-Post-Merge-1 re-enabled" (referencing the exact stage identifier "GB300-4_GPUs-PyTorch-Post-Merge-1") so operators won't be confused.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@jenkins/L0_Test.groovy`:
- Around line 2970-2972: Update the misleading comment that says "Disable GB300
stages due to nodes will be offline temporarily." to reflect that the
"GB300-4_GPUs-PyTorch-Post-Merge-1" stage is now enabled; locate the comment
above the GB300 stage entries and change it to something like "Adjust GB300
stages: most disabled, GB300-4_GPUs-PyTorch-Post-Merge-1 re-enabled"
(referencing the exact stage identifier "GB300-4_GPUs-PyTorch-Post-Merge-1") so
operators won't be confused.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 1cfe824e-1112-465e-bd6c-3e0d86479fa8
📒 Files selected for processing (1)
jenkins/L0_Test.groovy
Signed-off-by: Matt Lefebvre <mlefebvre@nvidia.com>
|
/bot run --disable-fail-fast --stage-list "GB300-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #43619 [ run ] triggered by Bot. Commit: |
|
PR_Github #43619 [ run ] completed with state
|
Signed-off-by: Matt Lefebvre <mlefebvre@nvidia.com>
|
/bot run --disable-fail-fast --stage-list "GB300-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #43639 [ run ] triggered by Bot. Commit: |
|
PR_Github #43639 [ run ] completed with state |
|
/bot run --disable-fail-fast --stage-list "GB300-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #43821 [ run ] triggered by Bot. Commit: |
|
PR_Github #43821 [ run ] completed with state
|
|
/bot run --disable-fail-fast --stage-list "GB300-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #43880 [ run ] triggered by Bot. Commit: |
|
PR_Github #43880 [ run ] completed with state
|
|
/bot run --disable-fail-fast --stage-list "GB300-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #44056 [ run ] triggered by Bot. Commit: |
|
PR_Github #44056 [ run ] completed with state |
|
/bot skip --comment "Sufficient testing" |
|
PR_Github #44485 [ skip ] triggered by Bot. Commit: |
|
PR_Github #44485 [ skip ] completed with state |
4 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.