[None][fix] Remove leftover onboardBlocks param in kvCacheManagerTest#13107
Conversation
Commit ec34644 removed the onboardBlocks parameter from the KVCacheManager constructor but missed the StoreBlocksForReuseWithPinDoesNotCreateGhostFreeBlocks test case, causing a compilation error. Signed-off-by: Yueh-Ting Chen <yueh.ting.chen@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe regression test Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --disable-fail-fast |
|
/bot skip --comment "Skipping as this is a small change and compile error should be fixed as soon as possible in the main branch" |
|
/bot skip --comment "Skipping as this is a small change and compile error should be fixed as soon as possible in the main branch" |
2 similar comments
|
/bot skip --comment "Skipping as this is a small change and compile error should be fixed as soon as possible in the main branch" |
|
/bot skip --comment "Skipping as this is a small change and compile error should be fixed as soon as possible in the main branch" |
|
PR_Github #43676 [ skip ] triggered by Bot. Commit: |
|
PR_Github #43676 [ skip ] completed with state |
…NVIDIA#13107) Signed-off-by: Yueh-Ting Chen <yueh.ting.chen@gmail.com>
Description
Commit ec34644 ("[None][chore] Remove onboard block switch for KV cache manager (#12449)") removed the
onboardBlocksparameter from theKVCacheManagerconstructor but missed theStoreBlocksForReuseWithPinDoesNotCreateGhostFreeBlockstest case inkvCacheManagerTest.cpp, causing a compilation error.This PR removes the leftover
onboardBlocksvariable and its usage from the constructor call.Test Coverage
StoreBlocksForReuseWithPinDoesNotCreateGhostFreeBlocks) will now compile and run correctly.PR Checklist
GitHub Bot Help
/bot run/bot helpSummary by CodeRabbit