[None][test] amend for qa weekly core test list#13153
Conversation
📝 WalkthroughWalkthroughA new model key mapping for Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
tests/integration/defs/perf/test_perf.py (1)
1-1: Update copyright year to 2026.The file is being modified in 2026, so the copyright year should be updated from
2022-2025to2022-2026. As per coding guidelines: "update year on modified files".Proposed fix
-# SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. +# SPDX-FileCopyrightText: Copyright (c) 2022-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/integration/defs/perf/test_perf.py` at line 1, Update the SPDX copyright header string "SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved." to reflect 2026 (change 2022-2025 to 2022-2026) so the file's copyright year matches the modification year; locate and replace that exact SPDX header line in the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/integration/defs/perf/test_perf.py`:
- Line 56: The entry for the model key "llama_v3.3_8b" uses the wrong path
"llama-models-v3/llama-v3-8b-instruct-hf"; update this value to follow the v3.3
naming convention by replacing it with "llama-3.3-models/Llama-3.3-8B-Instruct"
so it matches the pattern used by other v3.3 entries like
"llama_v3.3_70b_instruct".
In `@tests/integration/test_lists/qa/llm_perf_core.yml`:
- Around line 29-31: The YAML references model variants
(llama_v3.3_8b_instruct_fp8, llama_v3.3_8b_instruct, llama_v3.3_8b_instruct_fp4)
that are not defined and cause KeyError; add these variants to your model lookup
(e.g., extend MODEL_PATH_DICT or HF_MODEL_PATH) with entries that point to the
existing llama_v3.3_8b model path (or correct HF path), or add them to
allowed_configs.py if your validation expects explicit allowed names; ensure
keys exactly match the YAML names and reuse the same path/value as
MODEL_PATH_DICT["llama_v3.3_8b"] (or canonical HF id) so the tests resolve
without changing other code paths.
---
Nitpick comments:
In `@tests/integration/defs/perf/test_perf.py`:
- Line 1: Update the SPDX copyright header string "SPDX-FileCopyrightText:
Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved."
to reflect 2026 (change 2022-2025 to 2022-2026) so the file's copyright year
matches the modification year; locate and replace that exact SPDX header line in
the file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d352a92d-92c4-487c-906b-9d1bd95f6718
📒 Files selected for processing (2)
tests/integration/defs/perf/test_perf.pytests/integration/test_lists/qa/llm_perf_core.yml
5e30994 to
edd89d2
Compare
|
/bot skip --comment "skip test as just modifying cases" |
|
PR_Github #44359 [ skip ] triggered by Bot. Commit: |
|
PR_Github #44359 [ skip ] completed with state |
Signed-off-by: Ruodi Lu <ruodil@users.noreply.github.com>
Signed-off-by: Ruodi Lu <ruodil@users.noreply.github.com>
ff5109b to
4b75aae
Compare
|
/bot reuse-pipeline |
|
PR_Github #44667 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #44667 [ reuse-pipeline ] completed with state |
|
/bot skip --comment "only test list modify" |
|
PR_Github #44691 [ skip ] triggered by Bot. Commit: |
|
PR_Github #44691 [ skip ] completed with state |
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.