[None][chore] Add Dynamo configs to TRTLLM CI - Disagg - Part 1#13167
Conversation
📝 WalkthroughWalkthroughExtended performance sanity test infrastructure by adding two new model definitions to the test configuration and introducing three new disaggregated benchmark configurations for GB200 hardware with associated test list entries. Changes are configuration and data-driven additions with no control-flow modifications. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/defs/perf/test_perf_sanity.py (1)
1-1:⚠️ Potential issue | 🟠 MajorUpdate the copyright year on this modified Python file.
Line 1 still ends at
2025, but this file has meaningful changes in this PR and should reflect the latest year.🔧 Proposed fix
-# SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. +# SPDX-FileCopyrightText: Copyright (c) 2022-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.As per coding guidelines: All TensorRT-LLM source files must contain an NVIDIA copyright header with the year of latest meaningful modification.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/integration/defs/perf/test_perf_sanity.py` at line 1, Update the SPDX header year in the top-of-file comment for tests/integration/defs/perf/test_perf_sanity.py from 2025 to 2026 to reflect the latest meaningful modification; edit the first line that currently reads "...2022-2025 NVIDIA CORPORATION & AFFILIATES." and change the end year to 2026 so the copyright range becomes 2022-2026.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@tests/integration/defs/perf/test_perf_sanity.py`:
- Line 1: Update the SPDX header year in the top-of-file comment for
tests/integration/defs/perf/test_perf_sanity.py from 2025 to 2026 to reflect the
latest meaningful modification; edit the first line that currently reads
"...2022-2025 NVIDIA CORPORATION & AFFILIATES." and change the end year to 2026
so the copyright range becomes 2022-2026.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 58b8261c-ab58-4e65-8222-365c6144c0c2
📒 Files selected for processing (7)
tests/integration/defs/perf/test_perf_sanity.pytests/integration/test_lists/test-db/l0_gb200_multi_nodes_perf_sanity_ctx1_node1_gpu1_gen1_node1_gpu4.ymltests/integration/test_lists/test-db/l0_gb200_multi_nodes_perf_sanity_ctx1_node1_gpu4_gen1_node8_gpu32.ymltests/integration/test_lists/test-db/l0_gb200_multi_nodes_perf_sanity_ctx1_node2_gpu8_gen1_node2_gpu8.ymltests/scripts/perf-sanity/disaggregated/gb200_deepseek-r1-fp4_1k1k_con1024_ctx1_dep4_gen1_dep32_eplb0_mtp0_ccb-DEFAULT.yamltests/scripts/perf-sanity/disaggregated/gb200_deepseek-v32-fp4_32k4k_con256_ctx1_dep8_gen1_dep8_eplb0_mtp0_ccb-UCX.yamltests/scripts/perf-sanity/disaggregated/gb200_gpt-oss-120b-fp4_8k1k_con1024_ctx1_tp1_gen1_tp4_eplb0_mtp0_ccb-UCX.yaml
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
8d85337 to
a447b4e
Compare
|
/bot skip --comment "Only updating perf test configs, no need to run the whole CI pipeline." |
|
PR_Github #44228 [ skip ] triggered by Bot. Commit: |
|
PR_Github #44228 [ skip ] completed with state |
Description
This MR adds Dynamo configs to TRTLLM CI to catch issues early. This MR has disagg configs for gb200.
Test Coverage
N/A
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.