[None][chore] Add Dynamo configs to TRTLLM CI - Agg#13171
[None][chore] Add Dynamo configs to TRTLLM CI - Agg#13171brb-nv wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
| "DGX_B200-8_GPUs-PyTorch-PerfSanity-Post-Merge-2": ["auto:dgx-b200-flex", "l0_b200_multi_gpus_perf_sanity", 2, 4, 8, 1, true], | ||
| "DGX_B200-8_GPUs-PyTorch-PerfSanity-Post-Merge-3": ["auto:dgx-b200-flex", "l0_b200_multi_gpus_perf_sanity", 3, 4, 8, 1, true], | ||
| "DGX_B200-8_GPUs-PyTorch-PerfSanity-Post-Merge-4": ["auto:dgx-b200-flex", "l0_b200_multi_gpus_perf_sanity", 4, 4, 8, 1, true], | ||
| "DGX_H200-8_GPUs-PyTorch-PerfSanity-Post-Merge-1": ["dgx-h200-x8", "l0_dgx_h200_perf_sanity", 1, 1, 8, 1, true], |
There was a problem hiding this comment.
Question for infra reviewer: This is adding a new stage. Is there anything else we need to do?
📝 WalkthroughWalkthroughThis PR adds support for new performance sanity test configurations and models. Changes include a Jenkins stage definition for DGX H200 GPUs, registration of the Qwen3 32B FP8 model, new test entries across multiple test lists, and performance sanity YAML configurations for model deployments (Qwen3, GPT-OSS-120B, DeepSeek-V3.2, K25-thinking) on Blackwell and Hopper GPUs with specific tensor parallelism and throughput constraints. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/defs/perf/test_perf_sanity.py (1)
1-1:⚠️ Potential issue | 🟠 MajorUpdate the copyright year in the modified Python source header.
Line 1 still says
2022-2025even though this file is modified in 2026.✅ Proposed fix
-# SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. +# SPDX-FileCopyrightText: Copyright (c) 2022-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.As per coding guidelines, "All TensorRT-LLM source files must contain an NVIDIA copyright header with the year of latest meaningful modification."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/integration/defs/perf/test_perf_sanity.py` at line 1, Update the source header line that currently reads "2022-2025" to include the latest modification year (e.g., change to "2022-2026") so the file header reflects the 2026 modification; locate the top-of-file copyright header in test_perf_sanity.py and replace the year range accordingly.
🧹 Nitpick comments (1)
tests/scripts/perf-sanity/aggregated/dynamo_qwen3_235b_a22b_fp8_hopper.yaml (1)
15-15: Harden remote-code execution in CI configs.
trust_remote_code: trueis understandable for some model stacks, but it weakens CI safety. Please document why it is required here and prefer pinned/immutable model revisions when remote code is enabled.Also applies to: 47-47
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/scripts/perf-sanity/aggregated/dynamo_qwen3_235b_a22b_fp8_hopper.yaml` at line 15, The CI config enables unsafe remote-code execution via the YAML key trust_remote_code: true; update this to either trust_remote_code: false or, if remote code is required for this model, add an inline comment and a pinned immutable model revision (e.g., set model_revision to a specific commit/sha or exact model version) and document in the file why remote code is necessary for the model stack so reviewers can audit the change; ensure the same change is applied where trust_remote_code appears elsewhere in this file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@tests/integration/defs/perf/test_perf_sanity.py`:
- Line 1: Update the source header line that currently reads "2022-2025" to
include the latest modification year (e.g., change to "2022-2026") so the file
header reflects the 2026 modification; locate the top-of-file copyright header
in test_perf_sanity.py and replace the year range accordingly.
---
Nitpick comments:
In `@tests/scripts/perf-sanity/aggregated/dynamo_qwen3_235b_a22b_fp8_hopper.yaml`:
- Line 15: The CI config enables unsafe remote-code execution via the YAML key
trust_remote_code: true; update this to either trust_remote_code: false or, if
remote code is required for this model, add an inline comment and a pinned
immutable model revision (e.g., set model_revision to a specific commit/sha or
exact model version) and document in the file why remote code is necessary for
the model stack so reviewers can audit the change; ensure the same change is
applied where trust_remote_code appears elsewhere in this file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 51dc1d5b-dcac-462b-a4c0-524e8ccaedca
📒 Files selected for processing (11)
jenkins/L0_Test.groovytests/integration/defs/perf/test_perf_sanity.pytests/integration/test_lists/test-db/l0_b200_multi_gpus_perf_sanity.ymltests/integration/test_lists/test-db/l0_dgx_h200_perf_sanity.ymltests/integration/test_lists/test-db/l0_gb200_multi_gpus_perf_sanity.ymltests/integration/test_lists/test-db/l0_gb200_multi_nodes_perf_sanity_node2_gpu8.ymltests/scripts/perf-sanity/aggregated/dynamo_deepseek_v32_fp4_2_nodes_grace_blackwell.yamltests/scripts/perf-sanity/aggregated/dynamo_gpt_oss_120b_fp4_blackwell.yamltests/scripts/perf-sanity/aggregated/dynamo_k25_thinking_fp4_blackwell.yamltests/scripts/perf-sanity/aggregated/dynamo_qwen3_235b_a22b_fp8_hopper.yamltests/scripts/perf-sanity/aggregated/dynamo_qwen3_32b_fp8_hopper.yaml
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
12e9200 to
afecdd0
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #44078 [ run ] triggered by Bot. Commit: |
Description
This MR adds Dynamo configs to TRTLLM CI to catch issues early. This MR has agg configs.
Test Coverage
N/A
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Summary by CodeRabbit
New Features
Tests