Skip to content

[None][test] Remove triton_server test_opt#13173

Merged
StanleySun639 merged 1 commit intoNVIDIA:mainfrom
Tabrizian:user/imant/remove-test-opt
Apr 20, 2026
Merged

[None][test] Remove triton_server test_opt#13173
StanleySun639 merged 1 commit intoNVIDIA:mainfrom
Tabrizian:user/imant/remove-test-opt

Conversation

@Tabrizian
Copy link
Copy Markdown
Member

@Tabrizian Tabrizian commented Apr 18, 2026

Summary by CodeRabbit

  • Tests
    • Removed test cases for Triton server backend to streamline test suite.

Description

Removes the triton_server/test_triton.py::test_opt[opt] integration test and its corresponding listing in tests/integration/test_lists/test-db/l0_a30.yml. Continues the ongoing triton_server test cleanup.

Test Coverage

N/A — this PR removes a test; no new code paths are introduced.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Drop the test_opt[opt] entry from the triton_server integration suite
and its listing in l0_a30.yml.

Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com>
@Tabrizian Tabrizian requested a review from a team as a code owner April 18, 2026 02:08
@Tabrizian
Copy link
Copy Markdown
Member Author

/bot run --disable-fail-fast

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2762ee71-b77e-4b61-887e-5245fb569420

📥 Commits

Reviewing files that changed from the base of the PR and between 813d877 and 4632f59.

📒 Files selected for processing (2)
  • tests/integration/defs/triton_server/test_triton.py
  • tests/integration/test_lists/test-db/l0_a30.yml
💤 Files with no reviewable changes (2)
  • tests/integration/test_lists/test-db/l0_a30.yml
  • tests/integration/defs/triton_server/test_triton.py

📝 Walkthrough

Walkthrough

Removed the dedicated test_opt pytest test case from the Triton server test suite and its corresponding entries from the l0_a30 test configuration file for A30 GPUs.

Changes

Cohort / File(s) Summary
Test function removal
tests/integration/defs/triton_server/test_triton.py
Deleted test_opt() function that parameterized test_name as "opt", built the model, set tokenizer_type = "auto", and executed ./test.sh with related parameters.
Test configuration update
tests/integration/test_lists/test-db/l0_a30.yml
Removed triton_server/test_triton.py::test_opt[opt] and related triton_server/test_triton_llm.py::test_llmapi_backend test case entries from the l0_a30 stage configuration for Triton backend on A30 GPUs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing the test_opt test from triton_server.
Description check ✅ Passed The description follows the template structure and clearly explains what was removed, why (ongoing cleanup), and marks test coverage as N/A since the PR deletes rather than adds code.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@Tabrizian Tabrizian requested a review from longlee0622 April 18, 2026 02:09
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44083 [ run ] triggered by Bot. Commit: 4632f59 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44083 [ run ] completed with state SUCCESS. Commit: 4632f59
/LLM/main/L0_MergeRequest_PR pipeline #34513 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

CI Report

Link to invocation

@StanleySun639 StanleySun639 merged commit 7ae13fb into NVIDIA:main Apr 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants