Skip to content

[https://nvbugs/6013562][fix] Unwaive tests since the fix has been merged#13183

Merged
dongfengy merged 1 commit intoNVIDIA:mainfrom
dongfengy:user/dongfengy/kvunwaive2
Apr 19, 2026
Merged

[https://nvbugs/6013562][fix] Unwaive tests since the fix has been merged#13183
dongfengy merged 1 commit intoNVIDIA:mainfrom
dongfengy:user/dongfengy/kvunwaive2

Conversation

@dongfengy
Copy link
Copy Markdown
Collaborator

@dongfengy dongfengy commented Apr 19, 2026

…rged

Summary by CodeRabbit

  • Tests
    • Re-enabled testing for multi-GPU dual-model training scenarios, indicating improved stability for the feature.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…rged

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
@dongfengy dongfengy changed the title [https://nvbugs/6013562][fix] Unwaive tests since the fix has been me… [https://nvbugs/6013562][fix] Unwaive tests since the fix has been merged Apr 19, 2026
@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 99d386e7-04ad-469d-934b-ddbc766b6b43

📥 Commits

Reviewing files that changed from the base of the PR and between fc9d130 and 7cdefeb.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A single test waiver entry was removed from the test waiver list, indicating that a previously skipped test case no longer requires exemption.

Changes

Cohort / File(s) Summary
Test Waivers
tests/integration/test_lists/waives.txt
Removed waiver entry for accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_eagle3_vswa_reuse_4gpus[two_model] (previously skipped via nvbugs/6013562).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely empty, containing only the template structure without substantive content in required sections like Description, Test Coverage, or details about which tests are being unwaived. Fill in the Description section explaining why the test waiver was removed and confirm which specific tests are affected; provide Test Coverage details confirming the unwaived tests pass.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: removing a waiver entry from a test file because the underlying fix has been merged.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44155 [ run ] triggered by Bot. Commit: 7cdefeb Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44155 [ run ] completed with state SUCCESS. Commit: 7cdefeb
/LLM/main/L0_MergeRequest_PR pipeline #34582 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "confirmed with Claude, the test is not on CI, only on QA's list"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44208 Bot args parsing error: Failed to parse bot args

Link to invocation

@dongfengy
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "confirmed with Claude, the test is not on CI, only on QAs list"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44216 [ skip ] triggered by Bot. Commit: 7cdefeb Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44216 [ skip ] completed with state SUCCESS. Commit: 7cdefeb
Skipping testing for commit 7cdefeb

Link to invocation

@dongfengy dongfengy merged commit 41c4c68 into NVIDIA:main Apr 19, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants