Skip to content

[None][fix] Add missing aarch64 lib in cf9963f#13206

Merged
juney-nvidia merged 1 commit intoNVIDIA:mainfrom
pengbowang-nv:dev-fix-update-trtllm-gen-lib-for-aarch64
Apr 21, 2026
Merged

[None][fix] Add missing aarch64 lib in cf9963f#13206
juney-nvidia merged 1 commit intoNVIDIA:mainfrom
pengbowang-nv:dev-fix-update-trtllm-gen-lib-for-aarch64

Conversation

@pengbowang-nv
Copy link
Copy Markdown
Collaborator

@pengbowang-nv pengbowang-nv commented Apr 20, 2026

Summary by CodeRabbit

  • Chores
    • Updated internal TensorRT LLM kernel binary dependencies for aarch64 Linux systems.

Description

#12470 doesn't have update for aarch64 libs. This PR updates these libs.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Pengbo Wang <221450789+pengbowang-nv@users.noreply.github.com>
@pengbowang-nv pengbowang-nv changed the title [None][Fix] Add missing aarch64 lib in cf9963f [None][fix] Add missing aarch64 lib in cf9963f Apr 20, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

📝 Walkthrough

Walkthrough

Git LFS pointer metadata was updated for two compiled static library artifacts in the TensorRT LLM aarch64 Linux kernel directory. Both libraries received new SHA-256 hashes and reduced size values, reflecting updated binary artifacts.

Changes

Cohort / File(s) Summary
TensorRT LLM aarch64 Kernel Artifacts
cpp/tensorrt_llm/kernels/trtllmGenKernels/fmha/lib/aarch64-linux-gnu/libTrtLlmGen.a, cpp/tensorrt_llm/kernels/trtllmGenKernels/fmha/lib/aarch64-linux-gnu/libTrtLlmGenFmhaLib.a
Updated Git LFS pointer metadata with new OID (SHA-256) hashes and reduced size values for both static library files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description explains the issue (PR #12470 missing aarch64 libs) and solution (updating these libs), but Test Coverage and several PR Checklist items are left incomplete or unmarked. Add explicit test coverage details and verify all PR Checklist items are appropriately addressed or marked as N/A for binary library updates.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly identifies the primary change: adding missing aarch64 libraries and references the specific commit (cf9963f) that was incomplete.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@pengbowang-nv
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@pengbowang-nv pengbowang-nv requested a review from heyuhhh April 20, 2026 08:46
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44413 [ run ] triggered by Bot. Commit: b44ff6b Link to invocation

Copy link
Copy Markdown
Collaborator

@heyuhhh heyuhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ Thanks pengbo to fix this!

@pengbowang-nv
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44419 [ run ] triggered by Bot. Commit: b44ff6b Link to invocation

@pengbowang-nv
Copy link
Copy Markdown
Collaborator Author

/bot run --only-multi-gpu-test --gpu-type "GB200"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44434 [ run ] triggered by Bot. Commit: b44ff6b Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44434 [ run ] completed with state SUCCESS. Commit: b44ff6b
/LLM/main/L0_MergeRequest_PR pipeline #34840 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

CI Report

Link to invocation

@pengbowang-nv
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@pengbowang-nv pengbowang-nv enabled auto-merge (squash) April 20, 2026 13:58
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44465 [ run ] triggered by Bot. Commit: b44ff6b Link to invocation

@pengbowang-nv
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44496 [ run ] triggered by Bot. Commit: b44ff6b Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44496 [ run ] completed with state SUCCESS. Commit: b44ff6b
/LLM/main/L0_MergeRequest_PR pipeline #34896 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@pengbowang-nv
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44552 [ run ] triggered by Bot. Commit: b44ff6b Link to invocation

@heyuhhh
Copy link
Copy Markdown
Collaborator

heyuhhh commented Apr 21, 2026

/bot kill

@heyuhhh
Copy link
Copy Markdown
Collaborator

heyuhhh commented Apr 21, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44577 [ kill ] triggered by Bot. Commit: b44ff6b Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44578 [ run ] triggered by Bot. Commit: b44ff6b Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44577 [ kill ] completed with state ABORTED. Commit: b44ff6b

Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44552 [ run ] completed with state ABORTED. Commit: b44ff6b

Link to invocation

@juney-nvidia juney-nvidia disabled auto-merge April 21, 2026 03:38
@juney-nvidia juney-nvidia merged commit 27ba203 into NVIDIA:main Apr 21, 2026
6 of 12 checks passed
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44578 [ run ] completed with state SUCCESS. Commit: b44ff6b
/LLM/main/L0_MergeRequest_PR pipeline #34964 completed with status: 'SUCCESS'

CI Report

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants