[None][fix] Fix GPQA Diamond filter_type mismatch in disagg accuracy …#13210
Merged
fredricz-20070104 merged 1 commit intoNVIDIA:mainfrom Apr 20, 2026
Merged
Conversation
…test The disagg YAML declared filter_type: flexible-extract, but the lm_eval config tests/integration/lm_eval_configs/gpqa_diamond_local.yaml only defines a strict-match filter. As a result, the accuracy checker could not find the expected row and marked the case as a "Benchmark run error" in aggregated JUnit, even though the underlying run succeeded. GPQA is a multiple-choice task where strict-match is the correct filter; flexible-extract is semantically wrong here. Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Contributor
📝 WalkthroughWalkthroughA single YAML configuration file was modified to change the dataset accuracy validation filter type from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
Author
|
/bot skip --comment "Not cover in CI pipelines" |
fredricz-20070104
approved these changes
Apr 20, 2026
Collaborator
fredricz-20070104
left a comment
There was a problem hiding this comment.
Approved. This is a bug.
Collaborator
|
PR_Github #44407 [ skip ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #44407 [ skip ] completed with state |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…test
The disagg YAML declared filter_type: flexible-extract, but the lm_eval config tests/integration/lm_eval_configs/gpqa_diamond_local.yaml only defines a strict-match filter. As a result, the accuracy checker could not find the expected row and marked the case as a "Benchmark run error" in aggregated JUnit, even though the underlying run succeeded.
GPQA is a multiple-choice task where strict-match is the correct filter; flexible-extract is semantically wrong here.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.