Skip to content

[None][test] waive hang issues#13212

Merged
xinhe-nv merged 3 commits intoNVIDIA:mainfrom
xinhe-nv:wavie
Apr 21, 2026
Merged

[None][test] waive hang issues#13212
xinhe-nv merged 3 commits intoNVIDIA:mainfrom
xinhe-nv:wavie

Conversation

@xinhe-nv
Copy link
Copy Markdown
Collaborator

@xinhe-nv xinhe-nv commented Apr 20, 2026

Summary by CodeRabbit

  • Tests
    • Updated test waiver list to skip seven additional test configurations.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7c0b06fe-a37f-4451-883c-bfb7ed454d8c

📥 Commits

Reviewing files that changed from the base of the PR and between 33b3fd3 and 573a245.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Seven new SKIP entries were added to the test waivers list, covering a disaggregated single-GPU test and six PyTorch accuracy/API tests across different model architectures with specific parameter configurations. No existing waivers were modified.

Changes

Cohort / File(s) Summary
Test Waivers
tests/integration/test_lists/waives.txt
Added 7 new SKIP entries for disaggregated GPU and PyTorch accuracy/API tests with specific precision, backend, parallelism, and optimization flag configurations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template boilerplate with no actual content in the Description, Test Coverage, or issue explanation sections. Fill in the Description section explaining the hang issues being waived and why, and provide Test Coverage details about which tests are being waived.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][test] waive hang issues' follows the required format with ticket identifier and type, and clearly describes adding test waivers for hang-related issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44426 [ run ] triggered by Bot. Commit: 573a245 Link to invocation

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44426 [ run ] completed with state SUCCESS. Commit: 573a245
/LLM/main/L0_MergeRequest_PR pipeline #34837 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44554 [ reuse-pipeline ] triggered by Bot. Commit: 0113dc2 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44554 [ reuse-pipeline ] completed with state SUCCESS. Commit: 0113dc2
Reusing PR_Github #44426 (Partly Tested) for commit 0113dc2

Link to invocation

@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44566 [ reuse-pipeline ] triggered by Bot. Commit: a11b2ec Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44566 [ reuse-pipeline ] completed with state SUCCESS. Commit: a11b2ec
Reusing PR_Github #44426 (Partly Tested) for commit a11b2ec

Link to invocation

@xinhe-nv xinhe-nv merged commit 1ef4fbe into NVIDIA:main Apr 21, 2026
5 checks passed
@xinhe-nv xinhe-nv deleted the wavie branch April 21, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants