[None] [chore] Update .github/CODEOWNERS#13213
Conversation
Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
|
/bot skip --comment "code owners update" |
📝 WalkthroughWalkthroughAdded a new CODEOWNERS rule assigning ownership of Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/CODEOWNERS:
- Around line 213-214: The specific CODEOWNERS rule for
/examples/disaggregated/slurm/benchmark currently overrides the parent rule and
drops `@NVIDIA/trt-llm-disagg-devs` and `@NVIDIA/trt-llm-doc-owners`; update the
rule so it includes all parent owners plus the benchmark reviewers by changing
the owners on the /examples/disaggregated/slurm/benchmark line to
"@NVIDIA/trt-llm-disagg-devs `@NVIDIA/trt-llm-doc-owners`
`@NVIDIA/trtllm-bench-reviewers`" to ensure all required teams are listed (refer
to the two adjacent CODEOWNERS entries to locate and modify the rule).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 21f9b8e9-f117-4403-a2ce-2a61ab238ee0
📒 Files selected for processing (1)
.github/CODEOWNERS
|
/bot skip --comment "code owners update" |
|
PR_Github #44428 [ skip ] triggered by Bot. Commit: |
|
PR_Github #44429 [ skip ] triggered by Bot. Commit: |
|
PR_Github #44428 [ skip ] completed with state |
|
PR_Github #44429 [ skip ] completed with state |
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.