Skip to content

[None] [chore] Update .github/CODEOWNERS#13213

Merged
kaiyux merged 2 commits intomainfrom
user/kaiyu/update_code_owners
Apr 20, 2026
Merged

[None] [chore] Update .github/CODEOWNERS#13213
kaiyux merged 2 commits intomainfrom
user/kaiyu/update_code_owners

Conversation

@kaiyux
Copy link
Copy Markdown
Member

@kaiyux kaiyux commented Apr 20, 2026

Summary by CodeRabbit

  • Chores
    • Updated code ownership configuration for internal project governance.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
@kaiyux kaiyux requested review from a team as code owners April 20, 2026 09:28
@kaiyux kaiyux requested review from tburt-nv and yuanjingx87 April 20, 2026 09:28
@kaiyux
Copy link
Copy Markdown
Member Author

kaiyux commented Apr 20, 2026

/bot skip --comment "code owners update"

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

📝 Walkthrough

Walkthrough

Added a new CODEOWNERS rule assigning ownership of /examples/disaggregated/slurm/benchmark to the TensorRT-LLM benchmark reviewers team under the "TensorRT-LLM LLM Disaggregated" section.

Changes

Cohort / File(s) Summary
CODEOWNERS Configuration
.github/CODEOWNERS
Added ownership assignment for /examples/disaggregated/slurm/benchmark to @NVIDIA/trtllm-bench-reviewers.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is empty with only the template placeholders remaining. Required sections like Description, Test Coverage, and reasoning for CODEOWNERS changes are not filled in. Fill in the Description section explaining why the CODEOWNERS entry is being added and what it covers. Provide Test Coverage details and ensure the PR Checklist items are properly addressed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating the CODEOWNERS file with appropriate type classification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch user/kaiyu/update_code_owners

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/CODEOWNERS:
- Around line 213-214: The specific CODEOWNERS rule for
/examples/disaggregated/slurm/benchmark currently overrides the parent rule and
drops `@NVIDIA/trt-llm-disagg-devs` and `@NVIDIA/trt-llm-doc-owners`; update the
rule so it includes all parent owners plus the benchmark reviewers by changing
the owners on the /examples/disaggregated/slurm/benchmark line to
"@NVIDIA/trt-llm-disagg-devs `@NVIDIA/trt-llm-doc-owners`
`@NVIDIA/trtllm-bench-reviewers`" to ensure all required teams are listed (refer
to the two adjacent CODEOWNERS entries to locate and modify the rule).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 21f9b8e9-f117-4403-a2ce-2a61ab238ee0

📥 Commits

Reviewing files that changed from the base of the PR and between 33b3fd3 and e92edc0.

📒 Files selected for processing (1)
  • .github/CODEOWNERS

Comment thread .github/CODEOWNERS Outdated
@kaiyux kaiyux enabled auto-merge (squash) April 20, 2026 09:30
Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
@kaiyux
Copy link
Copy Markdown
Member Author

kaiyux commented Apr 20, 2026

/bot skip --comment "code owners update"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44428 [ skip ] triggered by Bot. Commit: ddcebd4 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44429 [ skip ] triggered by Bot. Commit: ddcebd4 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44428 [ skip ] completed with state ABORTED. Commit: ddcebd4

Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44429 [ skip ] completed with state SUCCESS. Commit: ddcebd4
Skipping testing for commit ddcebd4

Link to invocation

@kaiyux kaiyux merged commit 04915ad into main Apr 20, 2026
10 of 11 checks passed
@kaiyux kaiyux deleted the user/kaiyu/update_code_owners branch April 20, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants