[https://nvbugs/6050483][fix] pin diffusers version#13242
Conversation
|
/bot run --disable-fail-fast |
|
PR_Github #44518 [ run ] triggered by Bot. Commit: |
|
PR_Github #44518 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #44570 [ run ] triggered by Bot. Commit: |
|
PR_Github #44570 [ run ] completed with state |
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@requirements.txt`:
- Line 7: The main requirements.txt pins diffusers==0.37.1 but the mmdit
example's requirements file currently has diffusers>=0.32.2, causing a potential
mismatch when the example is used in isolation; update the mmdit example's
requirements (the mmdit example requirements file) to either pin diffusers to
the exact same version diffusers==0.37.1 or constrain it with an upper bound
such as diffusers>=0.32.2,<=0.37.1 so the diffusers package remains compatible
with the project's use of diffusers internals.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d10698ce-406c-410d-a549-e7cd296f8cfd
📒 Files selected for processing (3)
requirements.txttests/integration/defs/examples/test_visual_gen.pytests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (2)
- tests/integration/defs/examples/test_visual_gen.py
- tests/integration/test_lists/waives.txt
|
/bot run --disable-fail-fast |
|
PR_Github #44778 [ run ] triggered by Bot. Commit: |
|
PR_Github #44778 [ run ] completed with state
|
Signed-off-by: Olivia Stoner <245287810+o-stoner@users.noreply.github.com>
Signed-off-by: Olivia Stoner <245287810+o-stoner@users.noreply.github.com>
o-stoner
force-pushed
the
user/o-stoner/visual-gen-pin-diffusers
branch
from
943dc1e to
a1c46a1
Compare
Co-authored-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com> Signed-off-by: o-stoner <245287810+o-stoner@users.noreply.github.com>
Co-authored-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com> Signed-off-by: o-stoner <245287810+o-stoner@users.noreply.github.com>
Co-authored-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com> Signed-off-by: o-stoner <245287810+o-stoner@users.noreply.github.com>
Signed-off-by: Olivia Stoner <245287810+o-stoner@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #45004 [ run ] triggered by Bot. Commit: |
|
PR_Github #45004 [ run ] completed with state |
Signed-off-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com>
Signed-off-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com>
|
/bot run --disable-fail-fast --add-multi-gpu-test |
|
PR_Github #45671 [ run ] triggered by Bot. Commit: |
|
/bot run |
|
PR_Github #45798 [ run ] triggered by Bot. Commit: |
|
PR_Github #45798 [ run ] completed with state
|
Signed-off-by: o-stoner <245287810+o-stoner@users.noreply.github.com>
|
/bot run --disable-fail-fast --add-multi-gpu-test |
|
PR_Github #46668 [ run ] triggered by Bot. Commit: |
|
PR_Github #46668 [ run ] completed with state
|
|
/bot run --disable-fail-fast --add-multi-gpu-test |
Signed-off-by: o-stoner <245287810+o-stoner@users.noreply.github.com>
|
/bot run --disable-fail-fast --add-multi-gpu-test |
|
PR_Github #46838 [ run ] triggered by Bot. Commit: |
|
PR_Github #46838 [ run ] completed with state |
Signed-off-by: o-stoner <245287810+o-stoner@users.noreply.github.com>
|
/bot run --disable-fail-fast --add-multi-gpu-test |
|
PR_Github #47621 [ run ] triggered by Bot. Commit: |
|
PR_Github #47621 [ run ] completed with state
|
|
/bot run --disable-fail-fast --add-multi-gpu-test |
|
PR_Github #48022 [ run ] triggered by Bot. Commit: |
|
PR_Github #48022 [ run ] completed with state |
Signed-off-by: Olivia Stoner <245287810+o-stoner@users.noreply.github.com> Signed-off-by: o-stoner <245287810+o-stoner@users.noreply.github.com> Signed-off-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com> Co-authored-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com>
5 participants
Summary by CodeRabbit
Chores
diffuserspackage dependency to version 0.37.1 to ensure consistent and predictable package behavior.Tests
Description
We need to pin a Diffusers version per https://nvbugspro.nvidia.com/bug/6050483. We previously used
pip install git+https://github.com/huggingface/diffusers.gitin VisualGen, but that caused waived tests which we are aiming to bring back with this PR along with a pinned Diffusers version.Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.