[https://nvbugs/6080024][fix] Fix CudaGraphConfig validation conflict from YAML deep merge#13397
Conversation
Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
|
/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1" |
📝 WalkthroughWalkthroughTwo configuration updates are made: CUDA graph batch size alignment in a model registry configuration file, and test execution scheduling adjustment with a specific test case disabled in integration test configurations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/integration/test_lists/test-db/l0_dgx_b200.yml`:
- Line 376: The test
TestModelRegistryAccuracy::test_autodeploy_from_registry[deepseek-ai_DeepSeek-R1-0528-True]
was silently commented out; either re-enable it in the appropriate test stage or
quarantine it explicitly: if re-enabling, remove the comment so the test runs;
if quarantining, replace the commented entry with a quarantine record that
includes required metadata (nvbug/id, owner, target_reenable_date, and a short
reason) so the omission is tracked and automatically reviewable.
- Line 371: The section header "AutoDeploy Post Merge 8 GPU tests" and the stage
key "stage: pre_merge" are inconsistent; update either the header text to
"AutoDeploy Pre Merge 8 GPU tests" or change the stage value to "post_merge" so
the section label and the stage key match (look for the header string
"AutoDeploy Post Merge 8 GPU tests" and the YAML key "stage" in that block to
make the edit).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c0505814-4372-493c-81af-4ce5476d2bcd
📒 Files selected for processing (2)
examples/auto_deploy/model_registry/configs/qwen3.5_moe_400b.yamltests/integration/test_lists/test-db/l0_dgx_b200.yml
|
PR_Github #45251 [ run ] triggered by Bot. Commit: |
|
PR_Github #45251 [ run ] completed with state
|
|
/bot run --extra-stage "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1" |
|
PR_Github #46684 [ run ] triggered by Bot. Commit: |
|
/bot run --stage-list "DGX_B200-4_GPUs-AutoDeploy-1" |
|
PR_Github #46684 [ run ] completed with state
|
Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
|
/bot skip --comment "post merge test fix" |
|
is this the only affected model? could we proactively apply this fix to other model yamls? |
|
/bot skip --comment "post merge test fix" |
|
PR_Github #46834 [ skip ] triggered by Bot. Commit: |
|
PR_Github #46834 [ skip ] completed with state |
… from YAML deep merge (NVIDIA#13397) Signed-off-by: Chenghao Zhang <211069071+nvchenghaoz@users.noreply.github.com>
Summary by CodeRabbit
Chores
Tests
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.