[https://nvbugs/6117814][fix] Lower Eagle3 one-model acceptance rate threshold for H20 GPU#13565
Conversation
…d for H20 GPU The test_eagle3_one_model test was failing on H20-3e GPU because the acceptance rate threshold (25%) was calibrated for H100 but H20 achieves only ~21-22% acceptance rate due to different compute characteristics. Lower the threshold to 0.18 to accommodate H20 while still validating that speculative decoding is functioning correctly. Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adjusts the minimum speculative decoding acceptance-rate threshold in an integration test from 25% to 18%. The change modifies the pass/fail criterion for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --stage-list "H100_PCIe-AutoDeploy-1" |
|
/bot run --stage-list "H100_PCIe-AutoDeploy-1" |
|
/bot run |
|
PR_Github #45994 [ run ] triggered by Bot. Commit: |
|
PR_Github #45994 [ run ] completed with state
|
|
/bot run --stage-list "H100_PCIe-AutoDeploy-1" |
|
PR_Github #46177 [ run ] triggered by Bot. Commit: |
|
PR_Github #46177 [ run ] completed with state
|
|
/bot run --stage-list "H100_PCIe-AutoDeploy-1" |
|
PR_Github #46214 [ run ] triggered by Bot. Commit: |
|
PR_Github #46214 [ run ] completed with state |
|
/bot skip --comment "Change just makes test more permissive - and we confirmed that it still passed on CI. All relevant AutoDeploy tests pass." |
|
PR_Github #46400 [ skip ] triggered by Bot. Commit: |
|
PR_Github #46400 [ skip ] completed with state |
Summary
max_draft_len=3. This is not a correctness issue — accuracy tests pass — but rather a threshold calibration mismatch for this specific GPU architecture.Test plan
Links
Summary by CodeRabbit