[None][ci] Fix misleading still running log when Slurm job is PENDING#13586
[None][ci] Fix misleading still running log when Slurm job is PENDING#13586QiJune merged 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: junq <22017000+QiJune@users.noreply.github.com>
📝 WalkthroughWalkthroughUpdates a Slurm monitoring log message in Jenkins test configuration to display the resolved Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 9/10 reviews remaining, refill in 6 minutes. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
jenkins/L0_Test.groovy (1)
1374-1383:⚠️ Optional: makeSTATUShandling robust ifsacct --allocationsoutputs multiple lines.Right now
STATUS=$(sacct ... --format=State -Pn --allocations)can potentially contain multiple newline-separated states (depending on Slurm accounting granularity). The subsequent check does direct string equality comparisons, which can behave unexpectedly ifSTATUSis multi-line (e.g., theelsebranch may trigger even though the job is still transitioning).If in practice
sacct --allocationssometimes returns multiple states, consider normalizingSTATUSto a single token before both the condition and the log, e.g. selecting the last line:Suggested tweak (normalize `STATUS` to one state)
- STATUS=\$(sacct -j \$jobId --format=State -Pn --allocations) + STATUS=\$(sacct -j \$jobId --format=State -Pn --allocations | tail -n 1)This is optional and only needed if you confirm multi-line
STATUSoccurs in your Slurm environment.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@jenkins/L0_Test.groovy` around lines 1374 - 1383, The STATUS variable from the sacct call can be multi-line; update the assignment inside the loop (where STATUS=\$(sacct ... --format=State -Pn --allocations) is set) to normalize to a single token (e.g., extract the last non-empty line or last field) before the if-check and echo, then use that normalized STATUS for the equality checks and log messages so multi-line outputs won't break the RUNNING/PENDING/CONFIGURING comparisons.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@jenkins/L0_Test.groovy`:
- Around line 1374-1383: The STATUS variable from the sacct call can be
multi-line; update the assignment inside the loop (where STATUS=\$(sacct ...
--format=State -Pn --allocations) is set) to normalize to a single token (e.g.,
extract the last non-empty line or last field) before the if-check and echo,
then use that normalized STATUS for the equality checks and log messages so
multi-line outputs won't break the RUNNING/PENDING/CONFIGURING comparisons.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 5bf25ec6-cd47-4674-9649-f00c3d848b03
📒 Files selected for processing (1)
jenkins/L0_Test.groovy
|
/bot skip --comment "trivial changes" |
|
PR_Github #46022 [ skip ] triggered by Bot. Commit: |
|
PR_Github #46022 [ skip ] completed with state |
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.