Skip to content

[None][feat] tool template and parser for dsv4#13608

Merged
lfr-0531 merged 7 commits into
NVIDIA:feat/deepseek_v4from
Tracin:parser_dsv4
Apr 29, 2026
Merged

[None][feat] tool template and parser for dsv4#13608
lfr-0531 merged 7 commits into
NVIDIA:feat/deepseek_v4from
Tracin:parser_dsv4

Conversation

@Tracin
Copy link
Copy Markdown
Collaborator

@Tracin Tracin commented Apr 29, 2026

@coderabbitai summary

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@Tracin Tracin requested a review from a team as a code owner April 29, 2026 10:12
@Tracin Tracin requested review from zhenhuaw-me and removed request for a team April 29, 2026 10:12
@Tracin Tracin changed the title Parser dsv4 [None][feat] tool template and parser for dsv4 Apr 29, 2026
Tracin and others added 4 commits April 29, 2026 04:33
Add DeepSeek-V4 DSML tool-call chat formatting, parser registration, and focused tests for the vLLM-compatible prompt behavior.

Co-authored-by: OpenAI Codex <codex@openai.com>
Signed-off-by: Tracin <10434017+Tracin@users.noreply.github.com>
Add a DeepSeek-V4 reasoning parser alias that matches vLLM behavior by using identity parsing in chat mode and DeepSeek-R1 parsing when thinking is enabled. Register it for auto-detection and add focused parser tests.

Co-authored-by: OpenAI Codex <codex@openai.com>
Signed-off-by: Tracin <10434017+Tracin@users.noreply.github.com>
Remove the requested DeepSeek-V4 tool parser registration and initialization tests while keeping the shared parser behavior cases.

Co-authored-by: OpenAI Codex <codex@openai.com>
Signed-off-by: Tracin <10434017+Tracin@users.noreply.github.com>
Signed-off-by: Tracin <10434017+Tracin@users.noreply.github.com>
Tracin added 3 commits April 29, 2026 19:37
Signed-off-by: Qi Zhang (qizh) <10434017+Tracin@users.noreply.github.com>
Signed-off-by: Tracin <10434017+Tracin@users.noreply.github.com>
Signed-off-by: Tracin <10434017+Tracin@users.noreply.github.com>
@lfr-0531 lfr-0531 merged commit f1c5fe1 into NVIDIA:feat/deepseek_v4 Apr 29, 2026
4 checks passed
lfr-0531 pushed a commit that referenced this pull request May 7, 2026
Signed-off-by: Tracin <10434017+Tracin@users.noreply.github.com>
Signed-off-by: Qi Zhang (qizh) <10434017+Tracin@users.noreply.github.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
@Tracin Tracin deleted the parser_dsv4 branch May 12, 2026 03:02
lfr-0531 pushed a commit that referenced this pull request May 14, 2026
Signed-off-by: Tracin <10434017+Tracin@users.noreply.github.com>
Signed-off-by: Qi Zhang (qizh) <10434017+Tracin@users.noreply.github.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
Signed-off-by: Fanrong Li <lfr-0531@users.noreply.github.com>
lfr-0531 pushed a commit to lfr-0531/TensorRT-LLM that referenced this pull request May 29, 2026
Signed-off-by: Tracin <10434017+Tracin@users.noreply.github.com>
Signed-off-by: Qi Zhang (qizh) <10434017+Tracin@users.noreply.github.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
Signed-off-by: Fanrong Li <lfr-0531@users.noreply.github.com>
(cherry picked from commit eb97997)
Signed-off-by: Fanrong Li <lfr-0531@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants