Skip to content

[None][infra] llmc: stop managing .github/ in standalone package generator#13694

Merged
lucaslie merged 1 commit intoNVIDIA:mainfrom
nv-auto-deploy:ll/llmc-no-managed-github
May 2, 2026
Merged

[None][infra] llmc: stop managing .github/ in standalone package generator#13694
lucaslie merged 1 commit intoNVIDIA:mainfrom
nv-auto-deploy:ll/llmc-no-managed-github

Conversation

@lucaslie
Copy link
Copy Markdown
Member

@lucaslie lucaslie commented May 1, 2026

Summary

  • The standalone package generator (examples/auto_deploy/llmc/create_standalone_package.py) no longer wipes and recreates .github/ in its output directory.
  • Removes the examples/auto_deploy/llmc/.github_for_llmc/ template tree (issue templates, PR template).
  • .github/ joins .git/ in the script's preserved set; the standalone repo (NVIDIA/llm-compiler) now owns its own .github/ contents.

Why

The downstream mirror needs to own its own .github/ so it can host repo-specific things — issue/PR templates, CODEOWNERS, and (the motivating case) GitHub Actions workflows. Wiping the directory on every regeneration forced a save/restore dance in any CI living in the mirror; letting the mirror own the directory removes the friction and matches the existing convention for .git/.

The current contents of .github_for_llmc/ (ISSUE_TEMPLATE/config.yml and PULL_REQUEST_TEMPLATE.md) are byte-identical to what's already checked into NVIDIA/llm-compiler from the last regeneration, so no content is lost — they simply transition from upstream-templated to downstream-owned.

Test plan

  • Regenerate the standalone package against an existing NVIDIA/llm-compiler checkout that has a populated .github/; confirm .github/ is unchanged after the run.
  • Regenerate into a fresh empty directory; confirm the run completes without errors and .github/ is simply not created.
  • tests/unittest/auto_deploy/standalone/test_standalone_package.py still passes.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed GitHub issue template configuration and pull request template files from the repository
    • Simplified the standalone package generation process to no longer manage or copy GitHub template files, streamlining the build workflow

…rator

The standalone package generator no longer wipes or repopulates the
output directory's .github/ tree. Issue templates and PR template
that previously lived under examples/auto_deploy/llmc/.github_for_llmc/
are removed; the standalone repo (NVIDIA/llm-compiler) now owns its own
.github/ contents (templates, CODEOWNERS, workflows, etc.).

This lets the mirror host repo-specific automation (e.g. a scheduled
auto-uprev workflow) without a save/restore dance around every
regeneration. The current PR/ISSUE template files are byte-identical to
what is already checked in downstream, so no content is lost in the
transition.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
@lucaslie lucaslie requested a review from a team as a code owner May 1, 2026 19:02
@lucaslie lucaslie requested a review from MrGeva May 1, 2026 19:02
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 1, 2026

📝 Walkthrough

Walkthrough

This pull request removes GitHub issue and pull request template configurations from the llmc mirror repository and updates the standalone package generation script to exclude .github directory handling, simplifying the repository setup.

Changes

Cohort / File(s) Summary
GitHub Template Removal
examples/auto_deploy/llmc/.github_for_llmc/ISSUE_TEMPLATE/config.yml, examples/auto_deploy/llmc/.github_for_llmc/PULL_REQUEST_TEMPLATE.md
Deleted issue and PR template files that previously controlled GitHub template behavior and provided contributor guidance for the mirror repository.
Package Script Update
examples/auto_deploy/llmc/create_standalone_package.py
Removed .github directory source path constant, excluded .github from directory regeneration logic, and eliminated copy-tree logic that populated the output directory with .github templates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: stopping management of .github/ in the standalone package generator, which is the central purpose of this PR.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description comprehensively covers the changes, rationale, and test plan, addressing all key template sections effectively.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@lucaslie
Copy link
Copy Markdown
Member Author

lucaslie commented May 2, 2026

/bot run --stage-list "A10-Build_Docs, A10-PackageSanityCheck-PY310-UB2204, A100X-PackageSanityCheck-PY312-UB2404, H100_PCIe-AutoDeploy-1" --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #46533 [ run ] triggered by Bot. Commit: 3d6dc2f Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #46533 [ run ] completed with state SUCCESS. Commit: 3d6dc2f
/LLM/main/L0_MergeRequest_PR pipeline #36592 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@lucaslie
Copy link
Copy Markdown
Member Author

lucaslie commented May 2, 2026

/bot skip --comment "minor changes for llmc only"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #46560 [ skip ] triggered by Bot. Commit: 3d6dc2f Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #46560 [ skip ] completed with state SUCCESS. Commit: 3d6dc2f
Skipping testing for commit 3d6dc2f

Link to invocation

@lucaslie lucaslie merged commit add8a0e into NVIDIA:main May 2, 2026
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants