[None][infra] llmc: stop managing .github/ in standalone package generator#13694
Conversation
…rator The standalone package generator no longer wipes or repopulates the output directory's .github/ tree. Issue templates and PR template that previously lived under examples/auto_deploy/llmc/.github_for_llmc/ are removed; the standalone repo (NVIDIA/llm-compiler) now owns its own .github/ contents (templates, CODEOWNERS, workflows, etc.). This lets the mirror host repo-specific automation (e.g. a scheduled auto-uprev workflow) without a save/restore dance around every regeneration. The current PR/ISSUE template files are byte-identical to what is already checked in downstream, so no content is lost in the transition. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
📝 WalkthroughWalkthroughThis pull request removes GitHub issue and pull request template configurations from the llmc mirror repository and updates the standalone package generation script to exclude Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --stage-list "A10-Build_Docs, A10-PackageSanityCheck-PY310-UB2204, A100X-PackageSanityCheck-PY312-UB2404, H100_PCIe-AutoDeploy-1" --disable-fail-fast |
|
PR_Github #46533 [ run ] triggered by Bot. Commit: |
|
PR_Github #46533 [ run ] completed with state |
|
/bot skip --comment "minor changes for llmc only" |
|
PR_Github #46560 [ skip ] triggered by Bot. Commit: |
|
PR_Github #46560 [ skip ] completed with state |
Summary
examples/auto_deploy/llmc/create_standalone_package.py) no longer wipes and recreates.github/in its output directory.examples/auto_deploy/llmc/.github_for_llmc/template tree (issue templates, PR template)..github/joins.git/in the script's preserved set; the standalone repo (NVIDIA/llm-compiler) now owns its own.github/contents.Why
The downstream mirror needs to own its own
.github/so it can host repo-specific things — issue/PR templates, CODEOWNERS, and (the motivating case) GitHub Actions workflows. Wiping the directory on every regeneration forced a save/restore dance in any CI living in the mirror; letting the mirror own the directory removes the friction and matches the existing convention for.git/.The current contents of
.github_for_llmc/(ISSUE_TEMPLATE/config.ymlandPULL_REQUEST_TEMPLATE.md) are byte-identical to what's already checked intoNVIDIA/llm-compilerfrom the last regeneration, so no content is lost — they simply transition from upstream-templated to downstream-owned.Test plan
NVIDIA/llm-compilercheckout that has a populated.github/; confirm.github/is unchanged after the run..github/is simply not created.tests/unittest/auto_deploy/standalone/test_standalone_package.pystill passes.🤖 Generated with Claude Code
Summary by CodeRabbit