[None][fix] Clean up llmc licensing docs#13700
Conversation
fc6b55a to
7d79d85
Compare
📝 WalkthroughWalkthroughA new license and attribution generation module is introduced for the ChangesLicense and Attribution Generation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 9/10 reviews remaining, refill in 6 minutes. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@examples/auto_deploy/llmc/_license_data.py`:
- Around line 408-413: When license metadata is missing (info is falsy) for a
direct dependency, don't silently write "License: Unknown" and continue; instead
fail the generation by raising an error. Replace the current branch that appends
"License: Unknown" and continues so that if the dependency is direct (check the
direct-flag available in the loop—e.g., is_direct, dependency.is_direct, or
similar), raise a RuntimeError (or call sys.exit(1)) with a descriptive message
that includes dep_str; for non-direct/transitive deps you may keep the existing
fallback logging to lines as before. Ensure the raised error short-circuits
generation so missing license metadata for direct deps fails the build.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b04055af-0d8e-4b69-b118-26f6437aedd2
📒 Files selected for processing (2)
examples/auto_deploy/llmc/_license_data.pyexamples/auto_deploy/llmc/create_standalone_package.py
|
/bot run --stage-list "H100_PCIe-AutoDeploy-1" |
|
|
|
/bot run --stage-list "H100_PCIe-AutoDeploy-1" |
|
PR_Github #46534 [ run ] triggered by Bot. Commit: |
|
PR_Github #46534 [ run ] completed with state |
…LM's The extraction script was blindly copying TRT-LLM's entire LICENSE file, which listed 13 vendored projects — only 4-5 of which have code in the standalone package. This included the restrictive LTX-2 Community License for code not present in the repo. ATTRIBUTIONS-Python.md was not managed by the script at all, resulting in a stale 282-package file inherited from TRT-LLM. Changes: - Replace shutil.copy2(LICENSE) with _generate_license() that only includes the 6 vendored projects actually in auto_deploy - Add _generate_attributions() to produce ATTRIBUTIONS-Python.md from the 19 direct dependencies with known licenses - Add ATTRIBUTIONS-Python.md to _MANAGED_PATHS so it is regenerated on every extraction run Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
Signed-off-by: Balamurugan Marimuthu <246387390+bmarimuthu-nv@users.noreply.github.com>
7d79d85 to
bfae070
Compare
|
/bot run --stage-list "H100_PCIe-AutoDeploy-1" |
|
PR_Github #46686 [ run ] triggered by Bot. Commit: |
|
PR_Github #46686 [ run ] completed with state |
|
/bot skip --comment "llc packaging only - tested locally and passes AD stage test" |
|
PR_Github #46702 [ skip ] triggered by Bot. Commit: |
|
PR_Github #46702 [ skip ] completed with state |
Summary by CodeRabbit
New Features
Chores
Description
llm-commpiler repo license doc was a direct copy of trt-llm repo, includes all dependencies of trt-llm.
Instead let's have it reflect only the actual dependencies of llmc (which is a subset of trt-llm)
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.