Skip to content

[None][infra] Remove PULSE_REPO_BRANCH when running source code scanning#13778

Merged
yuanjingx87 merged 1 commit into
NVIDIA:mainfrom
yuanjingx87:user/yuanjingx/remove_pulse_repo_branch_for_source_code_scanning
May 5, 2026
Merged

[None][infra] Remove PULSE_REPO_BRANCH when running source code scanning#13778
yuanjingx87 merged 1 commit into
NVIDIA:mainfrom
yuanjingx87:user/yuanjingx/remove_pulse_repo_branch_for_source_code_scanning

Conversation

@yuanjingx87
Copy link
Copy Markdown
Collaborator

@yuanjingx87 yuanjingx87 commented May 5, 2026

It is not needed if we don't want to overrid nspect report

@coderabbitai summary

Description

Source code scanning might fail due to "nSpect verification returned 404 (Not Found) for NSPECT ID ***"

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

It is not needed if we don't want to overrid nspect report

Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
@yuanjingx87 yuanjingx87 requested review from a team as code owners May 5, 2026 20:46
@yuanjingx87 yuanjingx87 changed the title Remove PULSE_REPO_BRANCH when running source code scanning [None][infra] Remove PULSE_REPO_BRANCH when running source code scanning May 5, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

📝 Walkthrough

Walkthrough

The pull request removes the PULSE_REPO_BRANCH environment variable from the Pulse scanning step in the Jenkins TensorRT LLM pipeline configuration. This eliminates conditional logic that previously differentiated between fork and non-fork repository branch references.

Changes

Jenkins Pipeline Configuration

Layer / File(s) Summary
Environment Variable Removal
jenkins/TensorRT_LLM_PLC.groovy
PULSE_REPO_BRANCH environment variable entry removed from pulseScanSourceCode; no longer conditionally sets empty string for forks or ref value for non-forks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is incomplete and unclear. Title is missing proper format, and key sections lack sufficient detail about the change rationale and impact. Add a properly formatted title following [type] convention, expand the Description section to explain why PULSE_REPO_BRANCH removal fixes the nspect issue, and clarify Test Coverage approach for this infrastructure change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing PULSE_REPO_BRANCH from source code scanning configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@yuanjingx87
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "No need to run CI"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #46864 [ skip ] triggered by Bot. Commit: 0b43d09 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #46864 [ skip ] completed with state SUCCESS. Commit: 0b43d09
Skipping testing for commit 0b43d09

Link to invocation

@yuanjingx87 yuanjingx87 merged commit db3a93f into NVIDIA:main May 5, 2026
12 of 15 checks passed
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request May 19, 2026
…ing (NVIDIA#13778)

Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants