Skip to content

[https://nvbugs/6141806][test] unwaive disaggregated overlap gen-first tests#13807

Merged
reasonsolo merged 2 commits into
NVIDIA:mainfrom
reasonsolo:unwaive-disagg-overlap-gen-first-ctx-pp4
May 13, 2026
Merged

[https://nvbugs/6141806][test] unwaive disaggregated overlap gen-first tests#13807
reasonsolo merged 2 commits into
NVIDIA:mainfrom
reasonsolo:unwaive-disagg-overlap-gen-first-ctx-pp4

Conversation

@reasonsolo
Copy link
Copy Markdown
Collaborator

@reasonsolo reasonsolo commented May 6, 2026

Summary by CodeRabbit

  • Tests

    • Updated test configurations to skip certain tests on legacy hardware configurations.
    • Removed test waivers, enabling additional test coverage on compatible platforms.
  • Chores

    • Updated copyright header dates.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@reasonsolo reasonsolo requested a review from a team as a code owner May 6, 2026 12:21
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3983931b-db26-47a1-a27b-8229490f5990

📥 Commits

Reviewing files that changed from the base of the PR and between 7943536 and a8112ab.

📒 Files selected for processing (2)
  • tests/integration/defs/disaggregated/test_disaggregated.py
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A test decorator is added to skip test_disaggregated_overlap_gen_first on pre-hopper configurations, and corresponding skip entries are removed from the waives list. The copyright year is updated to 2026.

Changes

Skip Mechanism Migration

Layer / File(s) Summary
Skip Decorator
tests/integration/defs/disaggregated/test_disaggregated.py
Added @skip_pre_hopper decorator above test_disaggregated_overlap_gen_first to conditionally skip test on pre-hopper hardware configurations.
Waives List Update
tests/integration/test_lists/waives.txt
Removed two SKIP entries for ctx_pp1-TinyLlama and ctx_pp4-TinyLlama variants of the overlap_gen_first test, consolidating skip logic into the test decorator.
Metadata
tests/integration/defs/disaggregated/test_disaggregated.py
Copyright header year updated from 2022-2024 to 2022-2026.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely empty with only the template structure and a checked checklist item, missing the required Description and Test Coverage sections that explain the issue, solution, and test coverage. Add a Description section explaining why the tests are being unwaived and a Test Coverage section listing the specific tests affected by these changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: unwaiving (re-enabling) disaggregated overlap gen-first tests, which aligns with the code changes that add a skip decorator and remove waive entries.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@reasonsolo reasonsolo force-pushed the unwaive-disagg-overlap-gen-first-ctx-pp4 branch from a8112ab to fd1a29c Compare May 6, 2026 12:54
@reasonsolo
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@reasonsolo reasonsolo enabled auto-merge (squash) May 6, 2026 13:08
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47003 [ run ] triggered by Bot. Commit: fd1a29c Link to invocation

Copy link
Copy Markdown
Collaborator

@jieli-matrix jieli-matrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems https://nvbugs/6114142 & https://nvbugs/6085022 are also unwaived. However, @crazydemo triaged https://nvbugs/6114142 failed on GB300, which is not a pre-hopper case. I think we should only keep https://nvbugs/6141806 un-waive in the current PR.

@jieli-matrix
Copy link
Copy Markdown
Collaborator

/bot run --stage-list "DGX_H100-4_GPUs-CPP-1"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47008 [ run ] triggered by Bot. Commit: fd1a29c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47008 [ run ] completed with state SUCCESS. Commit: fd1a29c
/LLM/main/L0_MergeRequest_PR pipeline #36984 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@reasonsolo
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47201 [ run ] triggered by Bot. Commit: fd1a29c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47201 [ run ] completed with state SUCCESS. Commit: fd1a29c
/LLM/main/L0_MergeRequest_PR pipeline #37157 completed with status: 'SUCCESS'

CI Report

Link to invocation

Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
@reasonsolo reasonsolo force-pushed the unwaive-disagg-overlap-gen-first-ctx-pp4 branch from fd1a29c to e577b69 Compare May 8, 2026 06:23
@reasonsolo
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47332 [ run ] triggered by Bot. Commit: e577b69 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47332 [ run ] completed with state SUCCESS. Commit: e577b69
/LLM/main/L0_MergeRequest_PR pipeline #37270 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
@reasonsolo
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47947 [ run ] triggered by Bot. Commit: 72e53e5 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47947 [ run ] completed with state SUCCESS. Commit: 72e53e5
/LLM/main/L0_MergeRequest_PR pipeline #37789 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@reasonsolo
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #48047 [ run ] triggered by Bot. Commit: 72e53e5 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #48047 [ run ] completed with state SUCCESS. Commit: 72e53e5
/LLM/main/L0_MergeRequest_PR pipeline #37882 completed with status: 'SUCCESS'

CI Report

Link to invocation

@reasonsolo reasonsolo requested a review from xinhe-nv May 13, 2026 03:14
@reasonsolo reasonsolo merged commit 44d0b01 into NVIDIA:main May 13, 2026
6 checks passed
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request May 19, 2026
…t tests (NVIDIA#13807)

Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants