[None][doc] Update the image links in tech blog 19/20/21.#13838
Conversation
Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
|
/bot run |
📝 WalkthroughWalkthroughThis pull request updates three technical blog posts to host embedded figures on GitHub raw content URLs instead of relative local paths. Blog19 updates four figures, blog20 updates three figures and the author credit line, and blog21 updates ten figures throughout. All changes maintain document structure and content—only image source references change. ChangesBlog Image URL Migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/source/blogs/tech_blog/blog20_Tuning_CUDA_Graph_Batch_Sizes_for_Higher_Output_Throughput.md (1)
64-64: ⚡ Quick winPrefer commit-pinned raw image URLs for long-term doc stability.
These links target
raw/main, so future file moves/renames onmaincan break historical blog rendering. Consider pinning to a commit SHA (or a docs-hosted asset path) for immutable references.Also applies to: 77-77, 118-118
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/source/blogs/tech_blog/blog20_Tuning_CUDA_Graph_Batch_Sizes_for_Higher_Output_Throughput.md` at line 64, The image URL uses the volatile raw/main path; update the img src for the image named tech_blog20_aggr_all_models.png to a commit-pinned raw URL (replace raw/main with the specific commit SHA raw URL) or switch to a stable docs-hosted asset path, keeping the same alt and width attributes; apply the same change for the other blog image src occurrences mentioned (the two other image references in this file) so all image links are immutable.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@docs/source/blogs/tech_blog/blog20_Tuning_CUDA_Graph_Batch_Sizes_for_Higher_Output_Throughput.md`:
- Line 3: Replace the inconsistent author string "By NVIDIA TensorRT LLM Team"
with the normalized branding used elsewhere ("By TensorRT-LLM") in the blog
front-matter/header so it matches other updated posts; locate the author line
containing "By NVIDIA TensorRT LLM Team" and update it to "By TensorRT-LLM".
---
Nitpick comments:
In
`@docs/source/blogs/tech_blog/blog20_Tuning_CUDA_Graph_Batch_Sizes_for_Higher_Output_Throughput.md`:
- Line 64: The image URL uses the volatile raw/main path; update the img src for
the image named tech_blog20_aggr_all_models.png to a commit-pinned raw URL
(replace raw/main with the specific commit SHA raw URL) or switch to a stable
docs-hosted asset path, keeping the same alt and width attributes; apply the
same change for the other blog image src occurrences mentioned (the two other
image references in this file) so all image links are immutable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: ab5f95c0-192f-4691-9504-e3363fe30fa9
📒 Files selected for processing (3)
docs/source/blogs/tech_blog/blog19_DWDP_Distributed_Weight_Data_Parallelism_for_High_Performance_LLM_Inference_on_NVL72.mddocs/source/blogs/tech_blog/blog20_Tuning_CUDA_Graph_Batch_Sizes_for_Higher_Output_Throughput.mddocs/source/blogs/tech_blog/blog21_Temporal_Correlation_Meets_Sparse_Attention.md
|
PR_Github #47136 [ run ] triggered by Bot. Commit: |
|
PR_Github #47136 [ run ] completed with state |
Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.