Skip to content

[None][chore] Unwaive stale autodeploy waives#13862

Merged
galagam merged 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:gagam/ad-unwaives
May 10, 2026
Merged

[None][chore] Unwaive stale autodeploy waives#13862
galagam merged 1 commit into
NVIDIA:mainfrom
nv-auto-deploy:gagam/ad-unwaives

Conversation

@galagam
Copy link
Copy Markdown
Collaborator

@galagam galagam commented May 7, 2026

Summary by CodeRabbit

  • Tests
    • Updated test waiver configuration, refining which tests are skipped across different backend configurations to improve testing coverage accuracy.

Description

Test Coverage

/bot run --stage-list "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1,DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1"

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented May 7, 2026

/bot run --stage-list "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1,DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1"

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 73c5b7b6-837d-4101-9d4f-66938a2f4f05

📥 Commits

Reviewing files that changed from the base of the PR and between 2f79ebb and 494c9a2.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

The pull request updates the test waiver list to replace accuracy test case exclusions. Entries for GLM4Flash and Nemotron* models are removed, while new exclusions are added for Llama3.1 8B Instruct Eagle3 and a specific Llama-3.3 70B Instruct model registry test case.

Changes

Test Waiver Configuration

Layer / File(s) Summary
Skip List Configuration
tests/integration/test_lists/waives.txt
SKIP entries added for TestLlama3_1_8B_Instruct_Eagle3 (flashinfer and trtllm backends) and TestModelRegistryAccuracy for meta-llama Llama-3.3-70B-Instruct. Prior SKIP entries for GLM4Flash and Nemotron* configurations removed.

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing (unwaiving) stale auto-deploy test waivers from the test skip list.
Description check ✅ Passed The description includes relevant NVBugs references and test coverage commands, following the template structure with populated Description and Test Coverage sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47232 [ run ] triggered by Bot. Commit: 494c9a2 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47232 [ run ] completed with state SUCCESS. Commit: 494c9a2
/LLM/main/L0_MergeRequest_PR pipeline #37185 (Partly Tested) completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

CI Report

Link to invocation

@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented May 8, 2026

/bot run

@galagam galagam enabled auto-merge (squash) May 8, 2026 00:32
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47263 [ run ] triggered by Bot. Commit: 494c9a2 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47263 [ run ] completed with state SUCCESS. Commit: 494c9a2
/LLM/main/L0_MergeRequest_PR pipeline #37207 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented May 8, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47320 [ run ] triggered by Bot. Commit: 494c9a2 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47320 [ run ] completed with state SUCCESS. Commit: 494c9a2
/LLM/main/L0_MergeRequest_PR pipeline #37261 completed with status: 'SUCCESS'

CI Report

Link to invocation

@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented May 8, 2026

/bot run --stage-list "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1,DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47389 [ run ] triggered by Bot. Commit: f32d22a Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47389 [ run ] completed with state SUCCESS. Commit: f32d22a
/LLM/main/L0_MergeRequest_PR pipeline #37319 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Signed-off-by: Gal Hubara Agam <96368689+galagam@users.noreply.github.com>
@galagam galagam force-pushed the gagam/ad-unwaives branch from f32d22a to e01efc2 Compare May 10, 2026 05:56
@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented May 10, 2026

/bot run --stage-list "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1,DGX_B200-8_GPUs-AutoDeploy-Post-Merge-1"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47565 [ run ] triggered by Bot. Commit: e01efc2 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47565 [ run ] completed with state FAILURE. Commit: e01efc2
/LLM/main/L0_MergeRequest_PR pipeline #37477 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented May 10, 2026

/bot run --stage-list "DGX_B200-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-1, DGX_H100-4_GPUs-AutoDeploy-Post-Merge-1"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47574 [ run ] triggered by Bot. Commit: e01efc2 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47574 [ run ] completed with state SUCCESS. Commit: e01efc2
/LLM/main/L0_MergeRequest_PR pipeline #37485 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@galagam
Copy link
Copy Markdown
Collaborator Author

galagam commented May 10, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47585 [ run ] triggered by Bot. Commit: e01efc2 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47585 [ run ] completed with state SUCCESS. Commit: e01efc2
/LLM/main/L0_MergeRequest_PR pipeline #37495 completed with status: 'SUCCESS'

CI Report

Link to invocation

@galagam galagam merged commit 92f22ec into NVIDIA:main May 10, 2026
6 checks passed
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request May 19, 2026
Signed-off-by: Gal Hubara Agam <96368689+galagam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants